[Bug 15752] New: Automatically switch patron during circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Bug ID: 15752 Summary: Automatically switch patron during circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: chad@pennmanor.net QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Our library staff requested that koha automatically switch patrons when a patron barcode is scanned into the item barcode field during circulation. They frequently have large number of kids line up to checkout books and wanted this feature to speed up the process. I have implemented a patch that enables this functionality. To test: - Disable the autoswitchpatron system preference. - Go to the "Check out" section of a patron "circ/circulation.pl" - Enter a patron barcode into item barcode field. - You should get a message about the barcode not being found - Enable autoswitchpatron preference - Enter a patron barcode into the item barcode field - You should be redirected to that patron's circulation page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #1 from chad@pennmanor.net --- Created attachment 47716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47716&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |nengard@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Hi Chad, Patch works as expected but atomicupdate file should be a *.sql file instead of a *.pl file :-) Fix that and I can retest/signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Patch does no longer apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47716|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55953&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Easy conflict fixed, atomic .pl moved to .sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #6 from Marc Véron <veron@veron.ch> --- Hi Jonathan, With patch applied I can not open the checkout page e.g. from the link "My checkouts" or the link "Check out" at the left hand of a patron detail page. To make it work, I changed the following line: if (C4::Context->preference("AutoSwitchPatron") ) { to: if (C4::Context->preference("AutoSwitchPatron") && $query->param('barcode') ) { With this change, the patch behaves as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chad@pennmanor.net |ity.org | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd like to get feedback from others to know if it is a good behaviour to implement before fixing it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this could speed up things at the desk, but I have one worry: What happens when there is an overlap between item barcodes and patron cardnumbers? Maybe we should show a warning message in that case, asking if the number was one or the other before proceeding. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, if this is to avoid using the mouse to switch to the check-in field - have you seen that there are keyboard shortcuts for this too? From the circulation start page help: - jump to the catalog search with Alt+Q - jump to the checkout with Alt+U (this will not work for Mac user) - jump to the checkin with Alt+R -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #8)
I think this could speed up things at the desk, but I have one worry: What happens when there is an overlap between item barcodes and patron cardnumbers?
Maybe we should show a warning message in that case, asking if the number was one or the other before proceeding.
I think in the case of overlapping barcodes the feature should be turned off anyway, as the explanation for syspref AutoSwitchPatron says: "This should not be enabled if you have overlapping patron and book barcodes." If in the future a library with overlapping barcodes wants to have this feature, they can ask for or provide an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Fred <mediatheque.digne@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mediatheque.digne@gmail.com --- Comment #11 from Fred <mediatheque.digne@gmail.com> --- Hi, For autoswitch, in my library we use this JavaScript code (thanks to S.D.): ///////////////// $(document).ready(function () { if (window.location.href.indexOf("cgi-bin/koha/circ/circulation.pl") > -1) if ($("#circ_impossible ul li").html()) { var message = $("#circ_impossible ul li").html(); var terme = message.split(' '); var cb= terme[9]; var n= cb.length;} if (n==5) if (check_numerique(cb) == true) {$("#patronsearch #findborrower").val(cb); $("#patronsearch #autocsubmit").click(); } else {return false;} function check_numerique(input){ return !isNaN(input); } } //////////////////// This present 1 or 2 seconds the usual yellow message : Barcode not found we are satisfied with this solution for 1 year. Is it possible to make the same timing in this patch ? Thanks, Fred -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Joel <aloi54@live.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55953|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55953|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57015&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron Signed-off-by: Joel <aloi54@live.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not we add a message box if the switch happened? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
From the Koha log file:
circulation.pl: CGI::param called in list context from package main line 83, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://pro.kohadev.vm/cgi-bin/koha/circ/circulation-home.pl circulation.pl: Odd number of elements in anonymous hash at /home/vagrant/kohaclone/circ/circulation.pl line 83., referer: http://pro.kohadev.vm/cgi-bin/koha/circ/circulation-home.pl The search should only be done if the barcode field has been filled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57015|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 66175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66175&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron Signed-off-by: Joel <aloi54@live.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 66176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66176&action=edit Bug 15752: QA followup - search for patrons only if param barcode is defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 66177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66177&action=edit Bug 17572: QA followup - inform user that patron was automatically switched Test plan: 1) Start checking out to some patron - there should be no message about auto switching 2) read the another patrons card - note the patron is switched and there is a message about it at top of the main page content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #19 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Josef Sorry but failed in the running of QA test tools: OK circ/circulation.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template After that is fixed up I will be happy to test and signoff as the patches worked as described in the test plans -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66175|0 |1 is obsolete| | Attachment #66176|0 |1 is obsolete| | Attachment #66177|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67037&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron Signed-off-by: Joel <aloi54@live.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67038&action=edit Bug 15752: QA followup - search for patrons only if param barcode is defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67039&action=edit Bug 15752: QA followup - inform user that patron was automatically switched Test plan: 1) Start checking out to some patron - there should be no message about auto switching 2) read the another patrons card - note the patron is switched and there is a message about it at top of the main page content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Alex Buckley from comment #19)
Hi Josef
Sorry but failed in the running of QA test tools:
OK circ/circulation.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid
OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template
After that is fixed up I will be happy to test and signoff as the patches worked as described in the test plans
Did you have any conflicts applying the patches? For me it passes the QA test tools... Anyway, I rebased the patches on master and fixed commit message on 3rd patch (wrong bug number). Could you try it again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67037|0 |1 is obsolete| | --- Comment #24 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67174&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron Signed-off-by: Joel <aloi54@live.fr> Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67038|0 |1 is obsolete| | --- Comment #25 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67175&action=edit Bug 15752: QA followup - search for patrons only if param barcode is defined Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67039|0 |1 is obsolete| | --- Comment #26 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67176&action=edit Bug 15752: QA followup - inform user that patron was automatically switched Test plan: 1) Start checking out to some patron - there should be no message about auto switching 2) read the another patrons card - note the patron is switched and there is a message about it at top of the main page content Followed test plan, patch worked as described. Passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatically switch patron |Automatically switch from |during circulation |circulation to new patron | |when a cardnumber is | |scanned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67174|0 |1 is obsolete| | Attachment #67175|0 |1 is obsolete| | Attachment #67176|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69994&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron Signed-off-by: Joel <aloi54@live.fr> Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69995&action=edit Bug 15752: QA followup - search for patrons only if param barcode is defined Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 69996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69996&action=edit Bug 15752: QA followup - inform user that patron was automatically switched Test plan: 1) Start checking out to some patron - there should be no message about auto switching 2) read the another patrons card - note the patron is switched and there is a message about it at top of the main page content Followed test plan, patch worked as described. Passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70077&action=edit Bug 15752: Remove unecessary redirect We are on circulation.pl, no need to redirect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We should not need to redirect, we are on circulation.pl. Could someone take a look and retest quickly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70085&action=edit Bug 15752: Remove unecessary redirect (follow-up) If the borrowernumber is defined in query, it starts to get information about previous borrower and the new one is taken into account fully on second page reload -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #31)
We should not need to redirect, we are on circulation.pl. Could someone take a look and retest quickly?
True, but probably not so easy... I tested your patch and added followup - now it is working for me... but I am not sure if it is enough in all situations... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71359&action=edit Bug 15752: Automatically switch to patron when cardnumber is read during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron Signed-off-by: Joel <aloi54@live.fr> Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71360&action=edit Bug 15752: (follow-up) Search for patrons only if param barcode is defined Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71361&action=edit Bug 15752: (QA follow-up) Inform user that patron was automatically switched Test plan: 1) Start checking out to some patron - there should be no message about auto switching 2) read the another patrons card - note the patron is switched and there is a message about it at top of the main page content Followed test plan, patch worked as described. Passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71362&action=edit Bug 15752: (QA follow-up) Remove unecessary redirect We are on circulation.pl, no need to redirect. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71363&action=edit Bug 15752: (QA follow-up) Remove unecessary redirect If the borrowernumber is defined in query, it starts to get information about previous borrower and the new one is taken into account fully on second page reload Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatically switch from |Automatically switch from |circulation to new patron |circulation to new patron |when a cardnumber is |when a cardnumber is |scanned |scanned during circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The new system preference release notes| |AutoSwitchPatron allows to | |automatically switch to | |another patron record on | |scanning the cardnumber | |during circulation. This | |will allow to streamline | |processes at the | |circulation desk a bit | |more. Note: Use only if | |there is no overlap in your | |cardnumber and barcode | |ranges. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches pushed to master for 18.05. Congratulations Chad for your first patch in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backported to stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org