https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I've started with the batch record deletion tool. About the batch item deletion tool I am not sure how to process. Would it be correct to forbid the deletion in this case (in Koha::Item->safe_to_delete)? It is not trivial to add a confirmation screen on this tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I think blocking the deletion entirely is preferable to a confirmation box. Why warn the user that their intended action will make a mess that can only be corrected via a database update and then let them do it anyway? They should be instructed to go cancel the order(s) in acq. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Emma Ternrud from comment #0)

When a biblio with a linked order gets deleted you can not cancel the order.

There are two methods to delete a biblio: - Delete record in the edit menu - A check box when deleting all items using the batch deletion (see test plan).

The first method generates a warning message and the second method deletes with out warnings.

There should be warnings in both cases.

I think that we should definitely not delete biblio records if we have attached order lines that are new, ordered or partial. If there are, warn and do not delete. The user should cancel these lines and only then proceed to delete the biblio record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking if I can get some new code here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118025|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 162271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162271&action=edit Bug 27893: Cancel acq orders in addbiblio.pl When the user confirms removal although we have linked orders, we should cancel them. Test plan: Add order line to a basket. Goto newly added biblio record, remove items, remove biblio. Notice the warning about attached order lines. Confirm. Check the basket again after deletion took place (cancelled line). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hope this can start moving again. A simple approach for batch delete which can be extended later on if really needed. When we decide to delete, we now make sure that orders are cancelled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #13 from David Nind <david@davidnind.com> --- The patch no longer applies (also has whitespace errors): Bug 27893 Depends on bug 36068 (Needs Signoff) Follow? [(y)es, (n)o] y Bug 36068 - Add maintenance script acq_cancel_obsolete_orders.pl 162261 - Bug 36068: Add maint script acq_cancel_obsolete_orders.pl 162262 - Bug 36068: Do not overwrite cancellation date in ->cancel Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36068: Add maint script acq_cancel_obsolete_orders.pl Applying: Bug 36068: Do not overwrite cancellation date in ->cancel Bug 27893 - Delete of biblio should warn about attached acq orders and cancel them 162271 - Bug 27893: Cancel acq orders in addbiblio.pl 162272 - Bug 27893: Optionally skip biblio with open orders in batch delete Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27893: Cancel acq orders in addbiblio.pl .git/rebase-apply/patch:59: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M cataloguing/addbiblio.pl .git/rebase-apply/patch:59: trailing whitespace. warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging cataloguing/addbiblio.pl CONFLICT (content): Merge conflict in cataloguing/addbiblio.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 27893: Cancel acq orders in addbiblio.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162271|0 |1 is obsolete| | Attachment #162272|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163669&action=edit Bug 27893: Cancel acq orders in addbiblio.pl When the user confirms removal although we have linked orders, we should cancel them. Test plan: Add order line to a basket. Goto newly added biblio record, remove items, remove biblio. Notice the warning about attached order lines. Confirm. Check the basket again after deletion took place (cancelled line). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #13)

The patch no longer applies (also has whitespace errors):

Bug 27893 Depends on bug 36068 (Needs Signoff) Follow? [(y)es, (n)o] y

Bug 36068 - Add maintenance script acq_cancel_obsolete_orders.pl

162261 - Bug 36068: Add maint script acq_cancel_obsolete_orders.pl 162262 - Bug 36068: Do not overwrite cancellation date in ->cancel

Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36068: Add maint script acq_cancel_obsolete_orders.pl Applying: Bug 36068: Do not overwrite cancellation date in ->cancel

Bug 27893 - Delete of biblio should warn about attached acq orders and cancel them

162271 - Bug 27893: Cancel acq orders in addbiblio.pl 162272 - Bug 27893: Optionally skip biblio with open orders in batch delete

Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27893: Cancel acq orders in addbiblio.pl .git/rebase-apply/patch:59: trailing whitespace.

warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M cataloguing/addbiblio.pl .git/rebase-apply/patch:59: trailing whitespace.

warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging cataloguing/addbiblio.pl CONFLICT (content): Merge conflict in cataloguing/addbiblio.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 27893: Cancel acq orders in addbiblio.pl

Thx for testing. Rebased now for CSRF changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163669|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 163676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163676&action=edit Bug 27893: Cancel acq orders in addbiblio.pl When the user confirms removal although we have linked orders, we should cancel them. Test plan: Add order line to a basket. Goto newly added biblio record, remove items, remove biblio. Notice the warning about attached order lines. Confirm. Check the basket again after deletion took place (cancelled line). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #18)

Signed-off-by: David Nind <david@davidnind.com>

Thanks. Please note the dependency (ies). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163677|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165003&action=edit Bug 27893: Optionally skip biblio with open orders in batch delete If the user unchecks the skip checkbox (on by default), we must make sure that order cancellation is done in background job. Test plan: Pick two biblios. One has linked open orders, the other not. Go to batch delete records. Select 'Enter list of numbers'. Enter both biblio numbers and check that only one is used on the follow-up form. Run the deletion without the skip open orders and verify that linked order line is cancelled. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Delete of biblio should |Deleting a bibliographic |warn about attached acq |record should warn about |orders and cancel them |attached acquisition orders | |and cancel them -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #24)

1) It looks like cancel is not actually checking for the status of an order line. Should we be able to cancel an already cancelled order, add a "not cancelled" to our search or do I miss something?

+ my @result = Koha::Acquisition::Orders->search( { biblionumber => $biblionumber } )->cancel;

Out of scope a bit? This plural cancel is just a wrapper around the singular cancel which did not check that before. The good news is that it actually does not really matter. It can be run again. Note the new check on not overwriting the cancellation date that I added recently. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165151&action=edit Bug 27893: (QA follow-up) Terminology See comment24. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165152&action=edit Bug 27893: (QA follow-up) Rephrase warning See comment24 as well. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #25)

(In reply to Katrin Fischer from comment #24)

...

1) It looks like cancel is not actually checking for the status of an order line. Should we be able to cancel an already cancelled order, add a "not cancelled" to our search or do I miss something?

+ my @result = Koha::Acquisition::Orders->search( { biblionumber => $biblionumber } )->cancel;

Out of scope a bit? This plural cancel is just a wrapper around the singular cancel which did not check that before. The good news is that it actually does not really matter. It can be run again. Note the new check on not overwriting the cancellation date that I added recently.

I didn't expect you to fix cancel, just wondered if there should be another parameter to limit by status. - but reassured by your comment that the cancellation date would not be changed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Emily Lamancusa from comment #32)

It seems strange to me that even complete orders are cancelled when the linked biblio record is deleted. Is there a reason they need to be cancelled, rather than staying as "complete"?

Good question. Looking now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165620|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165621&action=edit Bug 27893: (follow-up) Check orderstatus in orders->cancel Removed the results[0] test too in addbiblio, since there can be warnings without effectively cancelled order lines. Also reworded the warn (cancelled, not deleted). Test plan: Run t/db_dependent/Koha/Acquisition/Orders.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #39 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the follow-up, Marcel! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.