[Bug 25400] New: Circulation and fine rules cloning from one table to another does not copy "current checkouts allowed"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Bug ID: 25400 Summary: Circulation and fine rules cloning from one table to another does not copy "current checkouts allowed" Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: joe@flo.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate this issue: 1. Create a rule in the main Circulation and Fines Rules table and provide a value for Current checkouts allowed such as 10. 2. Use the clone option to clone the rule you created to another library's table. 3. View the clone's table. 4. You should see that in the Current checkouts allowed column in the clone library that the value is now Unlimited. Cloning should copy all of the values from one library to another. See attached screenshots for an example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 --- Comment #1 from Joe Sikowitz <joe@flo.org> --- Created attachment 104455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104455&action=edit Example of original circ rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 --- Comment #2 from Joe Sikowitz <joe@flo.org> --- Created attachment 104456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104456&action=edit Examples of cloned circ rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Joe Sikowitz <joe@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104456|Examples of cloned circ |Example of cloned circ description|rules |rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joe, I think this is a duplicate of the very old bug 4225. Do you agree? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Joe, it works for me, which exact version of Koha are you using? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 --- Comment #5 from Joe Sikowitz <joe@flo.org> --- Hi Katrin, I looked at bug 4225 and it does look similar. I wasn't sure what only cloning the "top table" of rules meant since the bug I identified deals with the top most table on the page. That's why I submitted a new bug. Hi Jonathan, I am using Koha 19.05.09.000 and still seeing this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Joe Sikowitz from comment #5)
Hi Katrin, I looked at bug 4225 and it does look similar. I wasn't sure what only cloning the "top table" of rules meant since the bug I identified deals with the top most table on the page. That's why I submitted a new bug.
Hi Jonathan, I am using Koha 19.05.09.000 and still seeing this issue.
Ah, sorry then! We also got the current checkouts in the tables below, should have checked more closely! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104577&action=edit Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major Version|19.05 |19.11 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I've tested this, but it doesn't work for me when I copy from "All libraries" to any other library. Copying from library A to library B works well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104577|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104654&action=edit Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #8)
Hi Jonathan, I've tested this, but it doesn't work for me when I copy from "All libraries" to any other library. Copying from library A to library B works well.
Indeed, should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104654|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 104899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104899&action=edit Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on 19.11, no errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.06 released in| | Status|Signed Off |Passed QA CC| |joy@bywatersolutions.com --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25400 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|19.11.06 |19.11.06, 19.05.11 released in| | CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org