[Bug 13784] New: Koha-stop-zebra should also work for disabled instances
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Bug ID: 13784 Summary: Koha-stop-zebra should also work for disabled instances Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: larry@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Patch to come. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |larry@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 --- Comment #1 from Larry Baerveldt <larry@bywatersolutions.com> --- Created attachment 36412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36412&action=edit Koha-stop-zebra should also work for disabled instances Currently koha-stop-zebra will not stop zebra for disabled instances. It should work more like koha-stop-sip, which does work for disabled instances. Also, koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly should also apply to disabled instances. To Test: 1) Disable a koha instance. 2) Run koha-stop-zebra INSTANCE. You should get message "Instance INSTANCE disabled. No action taken." 3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra to package site over /usr/sbin/koha-stop-zebra. 4) Disable koha instance. 5) Run koha-stop-zebra INSTANCE. It should now stop zebra. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13785 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Wouldn't it make more sense to make to have koha-disable stop Zebra (if it does not do that atm)? Why would you have Zebra running for disabled instances and need to disable it with koha-stop-zebra? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Mirko Tietgen from comment #2)
Wouldn't it make more sense to make to have koha-disable stop Zebra (if it does not do that atm)? Why would you have Zebra running for disabled instances and need to disable it with koha-stop-zebra?
You are correct, but there's also no reason to have it not work if it could be useful in some weird circumstance. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 --- Comment #4 from Larry Baerveldt <larry@bywatersolutions.com> --- It's not even that weird of a situation. We often need to temporarily block access to a site for both the public catalog and the staff client (such as when performing maintenance, or other actions where we wouldn't want the database to be touched), and disabling the instance is the fastest way to do that, and still present a "maintenance" page to the user. Unless you remember to stop zebra manually first, then if you have already disabled the instance, then you *can't* stop zebra without just killing the processes. This patch addresses that. Also, I did just submit a patch for koha-disable to stop zebra (and SIP) (see 13785). However, for that patch to work, this one first has to be pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- Well the idea being that if koha-disable stops zebra, then zebra still running would be a weird situation :) I'm quite happy with all these patches, all going well I'll have a real look at them tomorrow and get them through. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36412|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36508&action=edit Koha-stop-zebra should also work for disabled instances Currently koha-stop-zebra will not stop zebra for disabled instances. It should work more like koha-stop-sip, which does work for disabled instances. Also, koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly should also apply to disabled instances. To Test: 1) Disable a koha instance. 2) Run koha-stop-zebra INSTANCE. You should get message "Instance INSTANCE disabled. No action taken." 3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra to package site over /usr/sbin/koha-stop-zebra. 4) Disable koha instance. 5) Run koha-stop-zebra INSTANCE. It should now stop zebra. http://bugs.koha-community.org/show_bug.cgi?id=13784 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 36520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36520&action=edit Bug 13784: Koha-stop-zebra should also work for disabled instances Currently koha-stop-zebra will not stop zebra for disabled instances. It should work more like koha-stop-sip, which does work for disabled instances. Also, koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly should also apply to disabled instances. To Test: 1) Disable a koha instance. 2) Run koha-stop-zebra INSTANCE. You should get message "Instance INSTANCE disabled. No action taken." 3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra to package site over /usr/sbin/koha-stop-zebra. 4) Disable koha instance. 5) Run koha-stop-zebra INSTANCE. It should now stop zebra. http://bugs.koha-community.org/show_bug.cgi?id=13784 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #36508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36520|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36728&action=edit Bug 13784: koha-stop-zebra should also work for disabled instances Currently koha-stop-zebra will not stop zebra for disabled instances. It should work more like koha-stop-sip, which does work for disabled instances. Also, koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly should also apply to disabled instances. To Test: 1) Disable a koha instance. 2) Run koha-stop-zebra INSTANCE. You should get message "Instance INSTANCE disabled. No action taken." 3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra to package site over /usr/sbin/koha-stop-zebra. 4) Disable koha instance. 5) Run koha-stop-zebra INSTANCE. It should now stop zebra. http://bugs.koha-community.org/show_bug.cgi?id=13784 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36729&action=edit Bug 13784: (QA followup) allow running Zebra for disabled instances on packages Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha-stop-zebra should also |Allow running Zebra daemon |work for disabled instances |for disabled instances in | |packages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- It is not clear to me that we should control disabled instances with /etc/init.d/koha-common as it is a special situation in which you want to run the zebra daemon on a disabled instance. Most people disable an instance and expect is to be off. I agree with adding some flexibility to the koha-{start|stop|restart}-zebra scripts, but I'm not sure we should change the current behaviour for the init script (i.e. removing --enabled). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36729|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 36730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36730&action=edit Bug 13784: (QA followup) allow running Zebra for disabled instances on packages Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Larry! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #14 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.9 nice one Larry :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org