[Bug 19524] New: Share patron lists between staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Bug ID: 19524 Summary: Share patron lists between staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse@bywatersolutions.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 75872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75872&action=edit Bug 19524: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 75873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75873&action=edit Bug 19524: Share patron lists between staff Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create or find two patrons with the manage_patron_lists permission 4) Using the first patron, create two new lists, mark one of them as shared 5) Log in as the second patron, browse to the patron lists page 6) Note the second patron can view, add and remove patrons from the shared list owned by the first patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 75874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75874&action=edit Bug 19524: Update Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75873|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 75878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75878&action=edit Bug 19524: Update database Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 75879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75879&action=edit Bug 19524: Share patron lists between staff Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create or find two patrons with the manage_patron_lists permission 4) Using the first patron, create two new lists, mark one of them as shared 5) Log in as the second patron, browse to the patron lists page 6) Note the second patron can view, add and remove patrons from the shared list owned by the first patron Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 75880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75880&action=edit Bug 19524: Update Schema files Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75878|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75891&action=edit Bug 19524: Update database Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75879|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75892&action=edit Bug 19524: Share patron lists between staff Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create or find two patrons with the manage_patron_lists permission 4) Using the first patron, create two new lists, mark one of them as shared 5) Log in as the second patron, browse to the patron lists page 6) Note the second patron can view, add and remove patrons from the shared list owned by the first patron Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75880|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75893&action=edit Bug 19524: Update Schema files Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- + logged_in_user => $loggedinuser, You should not do that, a Koha::Patron object is already passed using this variable name in C4::Auth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76992&action=edit Bug 19524: Use existing logged_in_user variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 [Bug 21129] New ALTER IGNORE TABLE entries need correction in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This reads like quite a behavior chance - moving things from being private to be shared. Would be good to have some text for the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, there is a new field 'shared', but it's not mentioned in the test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com Component|Architecture, internals, |Patrons |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #15)
This reads like quite a behavior chance - moving things from being private to be shared. Would be good to have some text for the release notes.
I have since tested this. As "Shared" is an opt-in on any list, this works well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org