https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159096&action=edit Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159096|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159118&action=edit Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159118|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 162390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162390&action=edit Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165609&action=edit Bug 35362: (follow-up) Fix preview close on guarantor add When adding a guarantor you are given a patron search modal. If you then preview a search result, the preview modal could not be closed. It's a simple update for 'close' to 'close_window' in the jQuery selector. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- There's another selenium failure further down the patron search test.. but I can't seem to resolve that one :(. More eyes are needed, please. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot to put a note: the first 2 follow-ups are already pushed to main. Not sure about the missing Selenium fix? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Tests still fail but we need this follow-up here. Working on it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked the follow-up "Adjust other..." for main. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.