[Bug 22619] New: Adding a new circ rule with unlimited checkouts is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Bug ID: 22619 Summary: Adding a new circ rule with unlimited checkouts is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- On bug 18925 we missed a case of fixing null/empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87305&action=edit Bug 22619: Fix null empty behaviour for new rules To test: 1 - Go to Admin->Circulation and fines rules 2 - Set All/All rules ot have a limit for Current checkouts allowed (and onsite checkouts allowed) 3 - Select an itemtype to add a new rule 4 - Save without entering any values 5 - Note that new rule displays with the same numebr as the all/all rule 6 - Check the DB, not no lines were added to circulation_rules table 7 - Delete the rule from the staff client 8 - Apply patch 9 - Repeat, note the new rule is unlimited 10 - Run selenium tests 11 - They pass! 12 - Check no rules/itemtypes are added to your system by the tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Selenium tests may be messy, I have not written them in some time, and the circ rules table has few identifying classes etc. We don't execute in a transaction, but I didn't know if this is intentional? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87305|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87331&action=edit Bug 22619: Fix null empty behaviour for new rules To test: 1 - Go to Admin->Circulation and fines rules 2 - Set All/All rules ot have a limit for Current checkouts allowed (and onsite checkouts allowed) 3 - Select an itemtype to add a new rule 4 - Save without entering any values 5 - Note that new rule displays with the same numebr as the all/all rule 6 - Check the DB, not no lines were added to circulation_rules table 7 - Delete the rule from the staff client 8 - Apply patch 9 - Repeat, note the new rule is unlimited 10 - Run selenium tests 11 - They pass! 12 - Check no rules/itemtypes are added to your system by the tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87331|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87364&action=edit Bug 22619: Fix null empty behaviour for new rules To test: 1 - Go to Admin->Circulation and fines rules 2 - Set All/All rules ot have a limit for Current checkouts allowed (and onsite checkouts allowed) 3 - Select an itemtype to add a new rule 4 - Save without entering any values 5 - Note that new rule displays with the same numebr as the all/all rule 6 - Check the DB, not no lines were added to circulation_rules table 7 - Delete the rule from the staff client 8 - Apply patch 9 - Repeat, note the new rule is unlimited 10 - Run selenium tests 11 - They pass! 12 - Check no rules/itemtypes are added to your system by the tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests all pass for me here.. joint QA effort. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87364|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87365&action=edit Bug 22619: Fix null empty behaviour for new rules To test: 1 - Go to Admin->Circulation and fines rules 2 - Set All/All rules ot have a limit for Current checkouts allowed (and onsite checkouts allowed) 3 - Select an itemtype to add a new rule 4 - Save without entering any values 5 - Note that new rule displays with the same numebr as the all/all rule 6 - Check the DB, not no lines were added to circulation_rules table 7 - Delete the rule from the staff client 8 - Apply patch 9 - Repeat, note the new rule is unlimited 10 - Run selenium tests 11 - They pass! 12 - Check no rules/itemtypes are added to your system by the tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87365|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87366&action=edit Bug 22619: Fix null empty behaviour for new rules To test: 1 - Go to Admin->Circulation and fines rules 2 - Set All/All rules ot have a limit for Current checkouts allowed (and onsite checkouts allowed) 3 - Select an itemtype to add a new rule 4 - Save without entering any values 5 - Note that new rule displays with the same numebr as the all/all rule 6 - Check the DB, not no lines were added to circulation_rules table 7 - Delete the rule from the staff client 8 - Apply patch 9 - Repeat, note the new rule is unlimited 10 - Run selenium tests 11 - They pass! 12 - Check no rules/itemtypes are added to your system by the tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Verified that the patch works, but failed to got the Selenium tests to pass before and after applying the patch. Leaving that to the next tester. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87365|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Depends on| |18925 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug with enhancement 18925 not in 18.11.x series Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #2)
We don't execute in a transaction, but I didn't know if this is intentional?
It will not help, they are simulating hits on the interface, so outside the transaction you would create. So, if the data is created using the interface, you need to delete them in the cleanup sub. And if the data is created from the test file, inside a transaction, the interface will have "see" it. For intance: 1. $itemtype is created using the admin form (click /admin/itemtypes.pl?op=add_form&itemtype=) => Need to be deleted in the cleanup sub 2. $itype is created using TestBuilder, inside a transaction => No need to delete it in the cleanup, but you will not be able to use it. It is useless 3. $itype is created using TestBuilder, without transaction (our case here) => You need to delete it, otherwise it will still exist after the test is ran. *And* you must delete it in the cleanup (called from END), to make sure the data will be deleted even if something goes wrong. A good example how to handle those data to delete is regression.t (push to @cleanup what we want to delete) Hope it makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Bug 22619 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Bug 22619 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org