[Bug 24911] New: Exception holidays treated as unique holidays in calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 Bug ID: 24911 Summary: Exception holidays treated as unique holidays in calendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@outlook.com QA Contact: testopia@bugs.koha-community.org When exception holiday is made it's still treated as unique holiday. Only days that aren't holidays but are included in the range of "Generate exceptions on a range of dates" are exceptions. To test: 1. Create holidays on a range e.g 23-24/3 2. Create exceptions on a range of 24-25/3 3. When editing: => 24/3 has label "Unique holiday" and is listed both in "Unique holidays" and "Exception holidays" lists => 25/3 has label "Holiday exception" and is listed only in "Exception holidays" Problems this is causing: 1. If you edit title and description of 24th day, you'll notice from holiday lists that edit only applies to unique holiday. In "Exception holidays" title and description remain the same. 2. When trying to delete 24th, only option "Delete this holiday" is given, not "Delete this exception" as it should. And if you use "Delete this holiday", unique holiday "beneath" exception gets deleted but day remains as exception holiday. Of course "Delete exceptions on range" still works and single exceptions can be deleted with it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 --- Comment #1 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Just to make clear, this only happens if exception is made for unique holidays. Exceptions for holidays repeating weekly and yearly work properly. And now when I looked closer, hint for option "Generate exceptions on a range of dates" says "You can make an exception on a range of dates repeated yearly." and there isn't option to make single exception for unique holidays like there is with repeatable holidays. So... there shouldn't even be option to add exceptions for unique holidays? How should this be handled, make exceptions work properly with unique holidays or hide option "Generate exceptions on a range of dates" if holiday is unique? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 --- Comment #2 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Ok, did some digging and I might have answered to my question myself. Patch with an option to generate exceptions on range for unique holidays was introduced in bug 7351. So it is where it should be, text in the hint just confused me. Sorry about this monologue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think there is no point to have an exception for a unique holiday = you could just delete it. So maybe we should not allow exceptions in that case and suggest to remove from the calendar instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 --- Comment #4 from Emmi Takkinen <emmi.takkinen@outlook.com> --- (In reply to Katrin Fischer from comment #3)
Hm, I think there is no point to have an exception for a unique holiday = you could just delete it. So maybe we should not allow exceptions in that case and suggest to remove from the calendar instead?
I agree. So we could just hide the option to generate exception when selected holiday is unique. Also seems like this was already reported in bug 9918. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 --- Comment #5 from Emmi Takkinen <emmi.takkinen@outlook.com> --- (In reply to Emmi Takkinen from comment #4)
(In reply to Katrin Fischer from comment #3)
Hm, I think there is no point to have an exception for a unique holiday = you could just delete it. So maybe we should not allow exceptions in that case and suggest to remove from the calendar instead?
I agree. So we could just hide the option to generate exception when selected holiday is unique. Also seems like this was already reported in bug 9918.
Wrong bug, meant bug 9118. It's somewhat same as this one, maybe some cleanup is in order for all options... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- It seems that this bug is no longer valid, since adding an exception to unique holiday is no longer possible. Setting this bug as RESOLVED FIXED. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org