https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155056&action=edit Bug 34684: Prevent 220600007.pl to fail if run twice The error is ERROR 1292 (22007): Truncated incorrect DECIMAL value: 'no' Happens on MariaDB 10.5.22, not MySQL 8 Test plan: update systempreferences set value="0" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "no" update systempreferences set value="1" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "issueslip" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #2)

How do you "play installer/data/mysql/db_revs/220600007.pl"? I can't run it on its own using Perl. Do we need to set Version to a particular number or something else?

Run the UPDATE query that is there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)

(In reply to David Cook from comment #2)

...

How do you "play installer/data/mysql/db_revs/220600007.pl"? I can't run it on its own using Perl. Do we need to set Version to a particular number or something else?

Run the UPDATE query that is there.

That won't trigger the DB update though and you can't run installer/data/mysql/db_revs/220600007.pl directly. I was testing a different bug of yours after this one and I came up with a test plan that I used, so tomorrow I could look at finding that and copying it over here... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- You can just copy the dbrev to atomicupdate to play it again. Dont forget to remove it later. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Fresh ktd, origin/master Server version: 10.5.22-MariaDB-1:10.5.22+maria~ubu2004 mariadb.org binary distribution MariaDB [koha_kohadev]> select value from systempreferences where variable="DisplayClearScreenButton"; +-------+ | value | +-------+ | no | +-------+ 1 row in set (0.000 sec) MariaDB [koha_kohadev]> UPDATE systempreferences SET options = 'no|issueslip|issueqslip', type = 'Choice', value = CASE value WHEN 1 THEN 'issueslip' ELSE 'no' END; ERROR 1292 (22007): Truncated incorrect DECIMAL value: '' Nothing else. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)

MariaDB [koha_kohadev]> UPDATE systempreferences SET options = 'no|issueslip|issueqslip', type = 'Choice', value = CASE value WHEN 1 THEN 'issueslip' ELSE 'no' END;

Wouldnt recommend this update (without WHERE).. I see the error now too. Upgrade to 22.06.00.007 [14:34:13]: Bug 29129 - Update the DisplayClearnScreenButton system pref to allow for a choice between ISSUESLIP and ISSUEQSLIP ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Truncated incorrect DECIMAL value: 'no' at /usr/share/koha/C4/Installer.pm line 741 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155275|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155276&action=edit Bug 34684: Prevent 220600007.pl to fail if run twice The error is ERROR 1292 (22007): Truncated incorrect DECIMAL value: 'no' Happens on MariaDB 10.5.22, not MySQL 8 Test plan: update systempreferences set value="0" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "no" update systempreferences set value="1" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "issueslip" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.