[Bug 13644] New: Paging Javascript breaks links with anchor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13644 Bug ID: 13644 Summary: Paging Javascript breaks links with anchor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I have a library asking me to put a link to the items tab of the MARC detail page on the normal detail page, so they can see the additional fields we have defined more easily. Trying to do this, turned up an oversight in the Javascript for the site paging. In order for a link with an anchor # to work, the anchor needs to be last on the link, but the browser.js will but the searchid= parameter at the end, so the link is broken. What needs to be done is to add the params directly after the other params and leave the #anchor at the end. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet... I have found no existing link that gets broken yet, but we could still fix this to make sure everywhere this script is used the links are created correctly. Example: Created link: https://staff.kopac.bsz-bw.de/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462#tab10XX&searchid=scs_1422610556359 Working link: https://staff.kopac.bsz-bw.de/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462&searchid=scs_1422610556359#tab10XX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13644 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have a library asking me to put a link to the items tab of the MARC detail page on the normal detail page, so they can see the additional fields we have defined more easily. Trying to do this, turned up an oversight in the Javascript for the site paging. In order for a link with an anchor # to work, the anchor needs to be last on the link, but the browser.js will but the searchid= parameter at the end, so the link is broken. What needs to be done is to add the params directly after the other params and leave the #anchor at the end. Line 101 http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet... I have found no existing link that gets broken yet, but we could still fix this to make sure everywhere this script is used the links are created correctly. Example: Created link: cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462#tab10XX&searchid=scs_1422610556359 Working link: cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462&searchid=scs_1422610556359#tab10XX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would be nice if the script was a bit more clever, but I figured out a workaround. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11937 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org