[Bug 19169] New: Add a test to detect unneeded 'atomicupdate' files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Bug ID: 19169 Summary: Add a test to detect unneeded 'atomicupdate' files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org Add a test to detect unneeded 'atomicupdate' files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What do you mean? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Are you asking for something in the release tools, like a git hook? I use one I can share if you want. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 131394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131394&action=edit Bug 19169: Add a test to detect unneeded 'atomicupdate' files to test... 1/ set git repo $ git reset --hard v21.11.03 2/ run test $ prove ./t OK 3/ apply patch 4/ run test again, observe FAIL $ prove ./t/00-check-atomic-updates.pl ./t/00-check-atomic-updates.pl .. 1/? # Failed test 'check for unhandled atomic updates: bug_29596.pl' # at ./t/00-check-atomic-updates.pl line 34. # 'bug_29596.pl' # matches '(?^u:.*pl$)' # Looks like you failed 1 test of 3. ./t/00-check-atomic-updates.pl .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker Priority|P5 - low |P1 - high --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #2)
Are you asking for something in the release tools, like a git hook? I use one I can share if you want.
hi Jonathan i added a test so we can catch this problem early, before the release :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29596 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- All RM and RMaints must have a pre-push hook with the following code in it. my @atomicupdate_files = `git show HEAD:installer/data/mysql/atomicupdate/|tr -s '\\n' | grep -v '^tree'|grep -v 'README'|grep -v skeleton`; chomp for @atomicupdate_files; for my $atomic ( @atomicupdate_files ) { push @errors, "Atomicupdate file exists - $atomic"; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131394|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131429&action=edit Bug 19169: Add a test to detect unneeded 'atomicupdate' files to test... 1/ set git repo $ git reset --hard v21.11.03 2/ run test $ prove ./t OK 3/ apply patch 4/ run test again, observe FAIL $ prove ./t/00-check-atomic-updates.pl ./t/00-check-atomic-updates.pl .. 1/? # Failed test 'check for unhandled atomic updates: bug_29596.pl' # at ./t/00-check-atomic-updates.pl line 34. # 'bug_29596.pl' # matches '(?^u:.*pl$)' # Looks like you failed 1 test of 3. ./t/00-check-atomic-updates.pl .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests JD Amended patch: fix copyright year Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #5)
All RM and RMaints must have a pre-push hook with the following code in it.
my @atomicupdate_files = `git show HEAD:installer/data/mysql/atomicupdate/|tr -s '\\n' | grep -v '^tree'|grep -v 'README'|grep -v skeleton`; chomp for @atomicupdate_files; for my $atomic ( @atomicupdate_files ) { push @errors, "Atomicupdate file exists - $atomic"; }
Should we add this to https://wiki.koha-community.org/wiki/Release_maintenance or https://wiki.koha-community.org/wiki/Tips_and_tricks#pre-push? Maybe we could also do a version of the RMaint pre-push hook that includes this check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131429|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131445&action=edit Bug 19169: Add a test to detect unneeded 'atomicupdate' files to test... 1/ set git repo $ git reset --hard v21.11.03 2/ run test $ prove ./t OK 3/ apply patch 4/ run test again, observe FAIL $ prove ./t/00-check-atomic-updates.pl ./t/00-check-atomic-updates.pl .. 1/? # Failed test 'check for unhandled atomic updates: bug_29596.pl' # at ./t/00-check-atomic-updates.pl line 34. # 'bug_29596.pl' # matches '(?^u:.*pl$)' # Looks like you failed 1 test of 3. ./t/00-check-atomic-updates.pl .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests JD Amended patch: fix copyright year Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #7)
Should we add this to https://wiki.koha-community.org/wiki/Release_maintenance or https://wiki.koha-community.org/wiki/Tips_and_tricks#pre-push?
It's there already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to Fridolin Somers from comment #10)
Pushed to master for 22.05, thanks to everybody involved 🦄
can we apply this thru to 19.11 pleeese -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |kyle@bywatersolutions.com, | |mtj@kohaaloha.com, | |victor@tuxayo.net, | |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.05 |22.05.00,21.11.05,21.05.14 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.05,21.05.14 |22.05.00,21.11.05,21.05.14, released in| |20.11.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.11.x branch for 20.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.05,21.05.14, |22.05.00,21.11.05,21.05.14, released in|20.11.18 |20.11.18,19.11.29 --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Note: has been backported and pushed to 19.11.x branch for 19.11.29 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31108 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 [Bug 31108] add missing shebang line to ./t/00-check-atomic-updates.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org