https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 95331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95331&action=edit Bug 24023: Add ability to create bundles of items This patch adds the ability to link items to a biblio to create bundles of items that can be reserved and checked out like a regular item. A withdrawn status will be set to linked items so that they can't be checked out while they are part of a bundle. When returning a bundle, the list of items that are part of this bundle will be displayed, allowing the librarian to verify that all items are there. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a biblio record with at least a title. Create an item for this biblio record 2. In the biblio 'Edit' menu you have a new option: 'Link elements'. Click on it 3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' 4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) 5. Verify that the withdrawn status has been correctly set for the items you have linked 6. Check that the biblionumber of the parent bibliographic record is in each linked items uri field 7. Verify that, for item created at step 1, items.materials has been updated with the number of items contained in the bundle 8. Edit the biblio record and remove one of the 462/774 fields 9. Verify that the corresponding item's withdrawn status has been reset 10. Check that the uri field in the corresponding items was removed 11. Checkout and checkin the item created at step 1 12. You should see the list of items contained in the bundle. Click on 'Confirm checkin without verifying'. Verify that the item has been returned 13. Checkout and checkin the item created at step 1 again 14. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' 15. Verify that the items corresponding to barcodes you did not type in the textarea are now marked as lost with the lost status you chose 16. Go to the inventory tool, use the bundle filter and verify that it works Sponsored-by: Bibliothèque Départementale de l'Yonne -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Hi Julian, I've got a tiny issue on step 6, for url is not complete (detail.pl?biblionumber= is missing). Did I forgot a setting somewhere ? Except this point, everything is ok for me ! In the future, do you think the feature could be decline to link items using the itemnumber ? I'm thinking of it for some of our collections, it would be really helpfull ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- I removed the parts that were modifying items.uri. The idea was to easily jump from the item to its bundle, but it may not be the best way. It can be added in another bug if needed. Back to needs signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Donna from comment #6)

Test plan fails at step 10. Deleting a 774 field has the following impact: a) the materials specified in the top level bib is removed

materials is at the item level (the item created at step 1). Can you confirm that you verified the item ? Because I can't reproduce the issue. For me the number in items.materials is correctly decreased.

b) items are still showing as attached in the 774, but the individual item records no longer show the withdrawn status and are instead showing as available.

You deleted a 774 field and it's still there ? Or do you mean that the other 774 fields (the ones that you have not deleted) are still there ?

If you continue with the test plan and check out the item from step 1, none of the attached items show as checked out, and upon checking in the item from step one, no list of titles.

None of the attached items should show as checked out, that's normal. https://snipboard.io/2zf1js.jpg : that's what you should get when checking in the item from step 1. You didn't have that ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cecile.joyet@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101555|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 109287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109287&action=edit Bug 24023: Add ability to create bundles of items This patch adds the ability to link items to a biblio to create bundles of items that can be reserved and checked out like a regular item. A withdrawn status will be set to linked items so that they can't be checked out while they are part of a bundle. When returning a bundle, the list of items that are part of this bundle will be displayed, allowing the librarian to verify that all items are there. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a biblio record with at least a title. Create an item for this biblio record 2. In the biblio 'Edit' menu you have a new option: 'Link elements'. Click on it 3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' 4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) 5. Verify that the withdrawn status has been correctly set for the items you have linked 6. Verify that, for item created at step 1, items.materials has been updated with the number of items contained in the bundle 7. Edit the biblio record and remove one of the 462/774 fields 8. Verify that the corresponding item's withdrawn status has been reset 9. Checkout and checkin the item created at step 1 10. You should see the list of items contained in the bundle. Click on 'Confirm checkin without verifying'. Verify that the item has been returned 11. Checkout and checkin the item created at step 1 again 12. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' 13. Verify that the items corresponding to barcodes you did not type in the textarea are now marked as lost with the lost status you chose 14. Go to the inventory tool, use the bundle filter and verify that it works Sponsored-by: Bibliothèque Départementale de l'Yonne -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109287|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 112275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112275&action=edit Bug 24023: Add ability to create bundles of items This patch adds the ability to link items to a biblio to create bundles of items that can be reserved and checked out like a regular item. A withdrawn status will be set to linked items so that they can't be checked out while they are part of a bundle. When returning a bundle, the list of items that are part of this bundle will be displayed, allowing the librarian to verify that all items are there. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a biblio record with at least a title. Create an item for this biblio record 2. In the biblio 'Edit' menu you have a new option: 'Link elements'. Click on it 3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' 4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) 5. Verify that the withdrawn status has been correctly set for the items you have linked 6. Verify that, for item created at step 1, items.materials has been updated with the number of items contained in the bundle 7. Edit the biblio record and remove one of the 462/774 fields 8. Verify that the corresponding item's withdrawn status has been reset 9. Checkout and checkin the item created at step 1 10. You should see the list of items contained in the bundle. Click on 'Confirm checkin without verifying'. Verify that the item has been returned 11. Checkout and checkin the item created at step 1 again 12. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' 13. Verify that the items corresponding to barcodes you did not type in the textarea are now marked as lost with the lost status you chose 14. Go to the inventory tool, use the bundle filter and verify that it works Sponsored-by: Bibliothèque Départementale de l'Yonne -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Séverine Queune <severine.queune@bulac.fr> --- Thanks Julian ! It's been a while I wanted to test that one !! It's a really great feature, and I have some questions about it.

3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' Could we imagine (in another bug probably to not block that one) to link items using itemnumber ? I think of using this feature for our "Recueils factices" (different small publications bound together) and they only have 1 barcode.

4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) Is it normal links between records are visible only on direction host > linked item, and not the other direction ? I didn't see information on a linked items record except on item table, and there are no informations displayed in the OPAC neither. Can we imagine a way to easily see the bundle items, without opening the MARC view, like a modal opening when clicking on the "Materials specified" number ?

9. Checkout and checkin the item created at step 1 When the item is checked out, linked items stay 'Available' on both intranet and OPAC, I don't think that clear enough for users.

12. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' I juste LOVE the highlight of item when you enter the barcode ! That's really clear to see which barcodes are missing !

14. Go to the inventory tool, use the bundle filter and verify that it works Is it a wish the host item is not displayed in the inventory list ? Buttons "Mark seen and continue" and "Continue without marking" don't work.

Mark it as failed because of the issue on inventory tool, and maybe the visibility of items checked out, but it's really great ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Séverine Queune <severine.queune@bulac.fr> --- Argh... Sorry Julian... Falling back to patching base and 3-way merge... Auto-merging tools/inventory.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging circ/returns.pl Auto-merging catalogue/detail.pl Auto-merging admin/columns_settings.yml Auto-merging C4/Items.pm Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 24023: Add ability to create bundles of items The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24023-Add-ability-to-create-bundles-of-items-nCjUy1.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119094|0 |1 is obsolete| | --- Comment #19 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 119554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119554&action=edit Bug 24023: Add ability to create bundles of items This patch adds the ability to link items to a biblio to create bundles of items that can be reserved and checked out like a regular item. A withdrawn status will be set to linked items so that they can't be checked out while they are part of a bundle. When returning a bundle, the list of items that are part of this bundle will be displayed, allowing the librarian to verify that all items are there. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a biblio record with at least a title. Create an item for this biblio record 2. In the biblio 'Edit' menu you have a new option: 'Link elements'. Click on it 3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' 4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) 5. Verify that the withdrawn status has been correctly set for the items you have linked 6. Verify that, for item created at step 1, items.materials has been updated with the number of items contained in the bundle 7. Edit the biblio record and remove one of the 462/774 fields 8. Verify that the corresponding item's withdrawn status has been reset 9. Checkout and checkin the item created at step 1 10. You should see the list of items contained in the bundle. Click on 'Confirm checkin without verifying'. Verify that the item has been returned 11. Checkout and checkin the item created at step 1 again 12. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' 13. Verify that the items corresponding to barcodes you did not type in the textarea are now marked as lost with the lost status you chose 14. Go to the inventory tool, use the bundle filter and verify that it works Sponsored-by: Bibliothèque Départementale de l'Yonne Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 --- Comment #21 from Séverine Queune <severine.queune@bulac.fr> --- I forgot 2 tiny modifications propositions on my last comment : after linking items, the table title 'Barcode' should be centred (I saw it align on right) and a colon is missing after the withdrawn label. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Martin Renvoize from comment #22)

Any chance of updating this to Koha:: space Julian? I note it's lacking unit tests and a move to Koha:: objects would be nice for future maintenance too.

Ah yes, tests are certainly needed. And I suppose it shouldn't be too hard to move it to Koha:: namespace while writing tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---

1. Create a biblio record with at least a title. Create an item for this biblio record

Can a 'bundle' record not contain multiple items? I could envisage a standard 'bundle' being created for various uses and then multiple 'items' consisting of a bundled set of materials.? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24857 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I find the idea really interesting. Have a few questions, though: - Can we do it in Koha::Item::Bundle(s) instead? Most of the C4::Items CRUD stuffs have been moved to Koha::Item(s) and we have a bunch of handy tools there. - Bundles would probably end-up being some kind of meta-item types. I don't see anything circ-related (for setting circulation rules on bundles). So, is it going to calculate the circ/hold rules based on one of the items? which? I would go the meta-item type way to simplify things. - Bug 24857 is introducing the concept of volumes at biblio level. Which sort-of have -implicitly- a similar meta-itype: in that case you place a hold on 'any copy of DVD 2 for Lord of the Rings'. It would be interesting to think how this dev will interact with that one: we could want to place a hold on the three LOTR movies (as a bundle), which would mean instead of a specific item, the bundle could include volume members instead. - How does checkout work for bundles? You check one item out, it identifies itself as part of a bundle, and checks all out? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've created a modernised version of this in bug 28854... it uses the Koha namespace and API as much as it can and improves on the UX I believe. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25503 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 [Bug 25503] Add option to export items bundle contents in checkouts table -- You are receiving this mail because: You are watching all bug changes.