[Bug 22960] New: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Bug ID: 22960 Summary: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 14576 Target Milestone: --- Typo found in circulation.pref in line 548. Paragraph: - "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned.<br/>" Typo: "locaiton" Permalink to github: https://github.com/Koha-Community/Koha/blob/0ed7cc0c577720f262110427ebe4d092... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 [Bug 14576] Allow automatic update of location on checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89955&action=edit Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89955|0 |1 is obsolete| | --- Comment #2 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 90072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90072&action=edit Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90072|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90121&action=edit Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90122&action=edit Bug 22960: Fix the same typo on db level for existing and new installations Seriously trying to kill the typo everywhere: - Check your DB with a report: select * from systempreferences where variable = 'UpdateItemLocationOnCheckin'; - Verify the typo in the explanation column: locaiton - Apply patch and run database update - Verify the typo is fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I went a little far with the follow-up... someone minding giving it a sign-off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90121|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90138&action=edit Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90122|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 90140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90140&action=edit Bug 22960: Fix the same typo on db level for existing and new installations Seriously trying to kill the typo everywhere: - Check your DB with a report: select * from systempreferences where variable = 'UpdateItemLocationOnCheckin'; - Verify the typo in the explanation column: locaiton - Apply patch and run database update - Verify the typo is fixed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90265&action=edit Bug 22960: (follow-up) Fix another tiny typo This only seems to appear in the .pref file: ...pairs. the => ... pairs. The -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90306&action=edit Bug 22960: (RM follow-up) Correct a further typo "This a list" changed to "This is a list" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org