[Bug 6835] New: Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Bug #: 6835 Summary: Ability to specify types of email address in overdue_notices.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Notices AssignedTo: henridamien@koha-fr.org ReportedBy: alex.arnaud@biblibre.com QAContact: koha-bugs@lists.koha-community.org This feature allows to specify an / some types of email address we want send to. It adds a '--email' parameter in overdue_notices.pl i.e "overdue_notices.pl --email B_email emailpro" patch is coming soon... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> 2011-09-02 09:44:18 UTC --- Created attachment 5281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5281 Ability to specify types of email address in overdue_notices.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:17 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:53 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #4 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-11-04 15:49:16 UTC --- Created attachment 6208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6208 Bug 6835 - Ability to specify types of email address in overdue_notices.pl - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Patch Status|Needs Signoff |Signed Off --- Comment #5 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-11-04 15:51:41 UTC --- Signed-off: - little code review - pertidy with no option on major part of the patch - this patch is in production for one of BibLibre customer and has been validated -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |alex.arnaud@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5281|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 19:18:11 UTC --- Claire, when you attach a signed-off patch with git bz, add the -e flag to obsolete the initial patch. For example: git bz attach -e 5281 HEAD WARNING: you'll be presented your editor to choose which patch(es) to obsolete. Be very quick. You've less than 30 seconds. If you're not fast enough, you'll get a nasty python error bacause your connecion to bugzilla will have be closed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-01-04 15:34:21 UTC --- Could you please resolve: CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6208|0 |1 is obsolete| | --- Comment #8 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 8712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8712&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |matthias.meusburger@biblibr | |e.com --- Comment #9 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Conflict solved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comments: overdue_notices.pl line 50/51: in the pod comments you break the line between script name and pl extension why do you set $email=1 on line 481 while you do not use it later anymore? why repeat the warning on line 489 (see line 472) ? redefinition of $letter: see lines 491/529; will raise warning $itemcount on line 489 not defined; warning too getletter on line 491 needs branchcode; warning too Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #11 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 9753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9753&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8712|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #12 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This new patch fixes M. de Rooy QA comments, except for : "why do you set $email=1 on line 481 while you do not use it later anymore?" $email is used line 515. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * I don't see the necessity of GetValidEmailAddresses sub. GetMember will return all email addresses (with other informations) * passes perlcritic Please answer my question #1 or provide a fix that does not create this new sub Also note that, if this sub is needed, a test will be welcomed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9753|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 10018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10018&action=edit Patch 6835 Fixed trivial conflict -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Do not want to step into your conversation ;) I do not oppose this new sub, but Paul's question deserves an answer first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #16 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- (En réponse au commentaire 13)
QA comments: * I don't see the necessity of GetValidEmailAddresses sub. GetMember will return all email addresses (with other informations)
GetMember does a heavier query than GetValidEmailAddresses. To my opinion, that unique point make the creation of GetValidEmailAddresses relevant, at a time we're trying to optimize koha. Moreover, the fetching of email addresses is done in nested loops. In such case, having lightweight queries does seem important to me. Do we agree on that ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: All earlier points have been revisited and corrected. Only discussion on routine left. Your query is somewhat lighter, but we still speak about one record. No objection however to this new routine. Let me put the status to Passed QA now and leave it to RM ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- After discussing of this with Matthias (hackfest), I mark failed QA = the gain in terms of performance is tiny, and it would add a sub that isn't necessary. We're trying to gain speed, but also remove code or at least not intruduce useless one) marking failed QA, sorry -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10018|0 |1 is obsolete| | --- Comment #19 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 10069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10069&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This new patch removes the GetValidEmailAddresses function (and uses GetMember instead). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- OK for changing existing routine. Final question: The if- condition ( @emails && !$nomail ) is clear, but what about its else-part? If the nomail flag is set, I think you should not send a mail. So please check that condition too in the else part (make it a elsif). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- In the former comment of June 11 a question was raised. But it is still unanswered. Changing status to reflect need for clarification/adjustment.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10069|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12036&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch is just a rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12036|0 |1 is obsolete| | --- Comment #25 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 12335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12335&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This new patch fixes the $nomail issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12335|0 |1 is obsolete| | --- Comment #27 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 12336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12336&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #28 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Changing target version so this bug report will show up in the list of 3.12-targeted features and doesn't get lost in the shuffle during feature freeze. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9103 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Small patch Version|3.12 |master --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, do you have time to take another look at this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #30 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Still two questions looking at the code again: 1) $email = C4::Members::GetFirstValidEmailAddress($borrowernumber); push @emails_to_use, $email; Shouldn't you test what you get back from this routine? Could be nothing. Could you use a temp variable instead of $email? (see point 2) 2) $email = 1 if (@emails_to_use); Does this work later on? I would rather test later on @emails_to_use and not change a variable that is a record value used in the while loop (l.488). See also line 535. And the template vars on 591/620. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835
--- Comment #31 from Matthias Meusburger <matthias.meusburger@biblibre.com> ---
1)
push @emails_to_use, $email if ($email ne '');
I also added line 497/498:
push @emails_to_use, $memberinfos->{$_}
if ($memberinfos->{$_} ne '');
2) It does work, but you're right, it's messy:
- $email = 1 if (@emails_to_use);
- if ( ( !$email || $nomail ) && $PrintNoticesMaxLines && $j
>= $PrintNoticesMaxLines ) {
+ if ( ( scalar(@emails_to_use) == 0 || $nomail ) &&
$PrintNoticesMaxLines && $j >= $PrintNoticesMaxLines ) {
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12336|0 |1 is obsolete| | --- Comment #32 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 14068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14068&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #33 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking at this one.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14068|0 |1 is obsolete| | --- Comment #34 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 14727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14727&action=edit Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Tested the cronjob with various settings of email parameter. QA Comment: This patch unfortunately took some time to reach this point. But hopefully we do now. Just some minor comments. (Thanks for paying attention to various details along the way!) The (double) use of $email in prepare_letter_for_printing is still little bit confusing. But could be taken care of in a followup. (In both cases there is no e-mail.) Could the email parameter be removed or just be empty in those two lines? Not an error, but just a thought: If I run perl misc/cronjobs/overdue_notices.pl -email email,emailpro I get: Use of uninitialized value in string ne at misc/cronjobs/overdue_notices.pl line 491. I know that I should do -email email -email emailpro and that works fine. But is it an idea to make it work too? Or should you better check the contents of this parameter and warn? (This may be somewhat hypothetical for a cronjob, I realize..) Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org