[Bug 30432] New: get_items_that_can_fill needs to specify table for biblionumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Bug ID: 30432 Summary: get_items_that_can_fill needs to specify table for biblionumbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When not using item_level-itypes i.e. it is set to 'bibliographic record', we join to biblioitems to get the itemtype This causes ambiguity in the 'filter_by_for_hold' call in 'get_items_that_can_fill' as we only specify 'biblionumber' in our bibs_or_items variable The error is: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132862&action=edit Bug 30432: Unit test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132863&action=edit Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132862|0 |1 is obsolete| | Attachment #132863|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132930&action=edit Bug 30432: Unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132931&action=edit Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tests are failing for me t/db_dependent/Koha/Holds.t .. 5/7 # Failed test 'Items 1, 2, and 5 are available for filling the holds' # at t/db_dependent/Koha/Holds.t line 516. # Structures begin differing at: # $got->[0] = '1006' # $expected->[0] = '1005' # Looks like you failed 1 test of 6. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This may be a fix, as we don't specify an order by clause in get_items_that_can_fill: - is_deeply( [ map { $_->itemnumber } $items->as_list ], + is_deeply( [ sort map { $_->itemnumber } $items->as_list ], -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132930|0 |1 is obsolete| | Attachment #132931|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133039&action=edit Bug 30432: Unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133040&action=edit Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133041&action=edit Bug 30432: Fix random failure Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.05 released in| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I get a bunch of errors from the QA tool after applying these to 21.05. Please rebase for backport: FAIL t/db_dependent/Koha/Holds.t FAIL valid Use of bare << to mean <<"" is deprecated Use of bare << to mean <<"" is deprecated Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$itype_2" requires explicit package name (did you forget to declare "my $itype_2"?) Global symbol "$item_1" requires explicit package name (did you forget to declare "my $item_1"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_2" requires explicit package name (did you forget to declare "my $item_2"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_3" requires explicit package name (did you forget to declare "my $item_3"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_4" requires explicit package name (did you forget to declare "my $item_4"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_1" requires explicit package name (did you forget to declare "my $itype_1"?) Global symbol "$item_5" requires explicit package name (did you forget to declare "my $item_5"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$itype_2" requires explicit package name (did you forget to declare "my $itype_2"?) Global symbol "$lost" requires explicit package name (did you forget to declare "my $lost"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$withdrawn" requires explicit package name (did you forget to declare "my $withdrawn"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) Global symbol "$notforloan" requires explicit package name (did you forget to declare "my $notforloan"?) Global symbol "$biblio" requires explicit package name (did you forget to declare "my $biblio"?) syntax error my " (Might be a runaway multi-line << string starting on line 419) t/db_dependent/Koha/Holds.t has too many errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133877&action=edit Bug 30432: [21.05.x] Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 30432: Unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 30432: Fix random failure Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org