[Bug 24126] New: Article requests tab appears twice on patron's checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Bug ID: 24126 Summary: Article requests tab appears twice on patron's checkout screen Change sponsored?: Sponsored Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/claimed-retu rned/ OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: bdaeuber@cityoffargo.com, bklein@dubuque.lib.ia.us, cbrannon@cdalibrary.org, clackman@fargolibrary.org, cmartin@rcplib.org, cslone@camdencountylibrary.org, daniel.gaghan@pueblolibrary.org, george@nekls.org, gmcharlt@gmail.com, horganl@middlesex.mass.edu, hughr@brimbank.vic.gov.au, joy@bywatersolutions.com, jwagner@ptfs.com, jzairo@bywatersolutions.com, katrin.fischer@bsz-bw.de, kelly@bywatersolutions.com, kyle.m.hall@gmail.com, kyle@bywatersolutions.com, lisetteslatah@gmail.com, margaret@bywatersolutions.com, marjorie.barry-vila@collecto.ca, martin.renvoize@ptfs-europe.com, niamh.walker-headon@it-tallaght.ie, tmisilo@gmail.com, tomascohen@gmail.com Depends on: 14697 Added by Bug 14697, the "Article requests" tab on the patron checkout screen now appears twice. Presumably a merge error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 95837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95837&action=edit Bug 24126: Article requests tab appears twice on patron's checkout screen This patch removes duplicated markup on the checkout page which results in the "Article requests" tab appearing twice. To test, apply the patch and enable ArticleRequests. Check out to a patron. In the set of tabs that includes checkouts, holds, restrictions, etc., the "Article requests" tab should appear only once. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95837|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 95838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95838&action=edit Bug 24126: Article requests tab appears twice on patron's checkout screen This patch removes duplicated markup on the checkout page which results in the "Article requests" tab appearing twice. To test, apply the patch and enable ArticleRequests. Check out to a patron. In the set of tabs that includes checkouts, holds, restrictions, etc., the "Article requests" tab should appear only once. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95838|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95869&action=edit Bug 24126: Article requests tab appears twice on patron's checkout screen This patch removes duplicated markup on the checkout page which results in the "Article requests" tab appearing twice. To test, apply the patch and enable ArticleRequests. Check out to a patron. In the set of tabs that includes checkouts, holds, restrictions, etc., the "Article requests" tab should appear only once. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement extends | release notes|the "Claims returned" lost | |status and allows staff to | |track items that patrons | |claim to have returned. | |Items are marked as "Claims | |returned" from the checkout | |page in the staff side. | | | |There are 3 new systems | |preferences to set for this | |functionality to work: | |`ClaimReturnedChargeFee`, | |`ClaimReturnedLostValue` | |and | |`ClaimReturnedWarningThresh | |old` | | | |Sponsored by: Fargo | |Public Library | |<http://fargond.gov/city-go | |vernment/departments/librar | |y> | |North Central Regional | |Library System | |<http://www.ncrl.org> | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Removed Release Notes text. Does not apply here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org