[Bug 22210] New: Allow organisations to sign up to Mana KB more easily
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Bug ID: 22210 Summary: Allow organisations to sign up to Mana KB more easily Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 17047 Target Milestone: --- The Mana KB registration form asks for first name and last name. I think a lot of libraries would prefer to sign up with a general account for the organisation (library@...). People can leave the library and more than one person might work with serials/reports. So I think tying the account to a person might not be the best way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I agree! As long as the Mana registration is global for the whole Koha instance it makes sense to allow for a more general account. Right now I don't think it's clear to the user why the interface asks for their name... Is that information going to be displayed somewhere? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Bug 22210 depends on bug 17047, which changed state. Bug 17047 Summary: Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |alex.arnaud@biblibre.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am upping severity... I really feel using a name here is wrong. I'd like to at least get a comment? I am not sure what would be needed to change it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Agreed, this is somewhat of a blocker for me too, I can't see our libraries adopting it as is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow organisations to sign |Allow organisations to sign |up to Mana KB more easily |up to Mana KB (don't only | |ask for firstname lastname) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 89854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89854&action=edit Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89854|0 |1 is obsolete| | --- Comment #5 from Michal Denar <black23@gmail.com> --- Created attachment 89923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89923&action=edit Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #6 from Michal Denar <black23@gmail.com> --- Hi Alex, patch works but if I follow ling filed Name, Last nname and e-mail are empty. I know it's on Mana server side ... Is it correct result? Thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michal Denar from comment #6)
Hi Alex, patch works but if I follow ling filed Name, Last nname and e-mail are empty. I know it's on Mana server side ... Is it correct result?
Thank you
I've also got some problems with the sign-up process. In my koha-conf.xml I have the mana test server, but when I register, the email I receive reads: https://ui.mana-kb.koha-community.org/registration?id=aa1JLPnpz6vBshtSpm2f6y... And clicking on it it tells me my token is too old or doesn't exist? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Web services |Mana-kb CC| |jonathan.druart@bugs.koha-c | |ommunity.org QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving to FQA. Needs feedback on the previous comments/questions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Michal Denar from comment #6)
Hi Alex, patch works but if I follow ling filed Name, Last nname and e-mail are empty. I know it's on Mana server side ... Is it correct result?
Thank you
Fixed on Mana server side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
(In reply to Michal Denar from comment #6)
Hi Alex, patch works but if I follow ling filed Name, Last nname and e-mail are empty. I know it's on Mana server side ... Is it correct result?
Thank you
I've also got some problems with the sign-up process. In my koha-conf.xml I have the mana test server, but when I register, the email I receive reads: https://ui.mana-kb.koha-community.org/ registration?id=aa1JLPnpz6vBshtSpm2f6yr4sKKmJZ26
And clicking on it it tells me my token is too old or doesn't exist?
Good catch Katrin! I fixed that in the configuration. Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89923|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90450&action=edit Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you Alex! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #13 from Alex Arnaud <alex.arnaud@biblibre.com> --- Mana pull request: https://git.biblibre.com/biblibre/koha-mana/pulls/3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #14 from Alex Arnaud <alex.arnaud@biblibre.com> --- Pull request: https://gitlab.com/koha-community/koha-mana/merge_requests/3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90450|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90592&action=edit Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90593&action=edit Bug 22210: (QA follow-up) Tiny gramatical correction Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works for me and passes QA scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- On second thoughts, I'm less sure about this.. do we need to version the Mana API as I believe the change on the mana server end is a breaking API change.. I know we're early days so nearly no-one would get caught by it right now, but we should probably get the procedures for such things in place now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just to clarify that.. if we pushed this as is now (and merged the request at the Mana end too).. then anyone running 19.05.00 Koha would need to use one Mana server whilst anyone running 19.05.01+ would need to point to another. This just highlights that we need to think differently during QA for this service. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are early enough, let's push this into 19.11.01 (which means now we have translation break, but better now than later) and fix the Mana server at release day if possible. But I agree that in general we should make sure things stay backwards compatible or version properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I'll push this as is but I really hope we get API versioning done during the .02 month as by .03 I think this will become a much bigger issue for end users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the Mana registration form | |to make it easier for | |organizations to register. | |It now only requires name | |and email address, rather | |than first name, last name | |and email address. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 --- Comment #23 from Alex Arnaud <alex.arnaud@biblibre.com> --- Mana test and prod are both up to date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.02 released in| | --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #25 from Lucas Gass <lucas@bywatersolutions.com> --- no backport for 18.11.x, missing dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This changes the Mana release notes|the Mana registration form |registration form to make |to make it easier for |it easier for organizations |organizations to register. |to register. It now only |It now only requires name |requires name and email |and email address, rather |address, rather than first |than first name, last name |name, last name and email |and email address. |address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow organisations to sign |ManaKB should not require |up to Mana KB (don't only |firstname and lastname; |ask for firstname lastname) |allowing organisations to | |sign up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ManaKB should not require |ManaKB should not require |firstname and lastname; |firstname and lastname |allowing organisations to | |sign up | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ManaKB should not require |ManaKB should not require |firstname and lastname |firstname and lastname for | |signup -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org