[Bug 26935] New: Incorrect basketid sent for claimacquisition and claimissues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Bug ID: 26935 Summary: Incorrect basketid sent for claimacquisition and claimissues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113033&action=edit Bug 26935: Don't use basket for claimacquisition and claimissues Incorrect basketid is sent for claimacquisition and claimissues. The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 This is a quick patch to fix the failing test, bug more work would needed. We are removing the basket info from those 2 notices and keeping it only for orderacquisition. Technically: the $externalid is coming from the parameter list of SendAlerts, but it is a basketno only for orderacquisition. We must not pass it for other notices. Test plan: Confirm that the failing test is now passing and that the changes make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patch has a high priority, Jenkins is not happy without it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113033|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113047&action=edit Bug 26935: Don't use basket for claimacquisition and claimissues Incorrect basketid is sent for claimacquisition and claimissues. The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 This is a quick patch to fix the failing test, bug more work would needed. We are removing the basket info from those 2 notices and keeping it only for orderacquisition. Technically: the $externalid is coming from the parameter list of SendAlerts, but it is a basketno only for orderacquisition. We must not pass it for other notices. Test plan: Confirm that the failing test is now passing and that the changes make sense. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yikes, that sub is kinda horrible.. but that's cleanup for another day. I agree with your changes here and the tests now pass consistently. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113118&action=edit Bug 26935: Don't use basket for claimacquisition and claimissues Incorrect basketid is sent for claimacquisition and claimissues. The basket info are not used in the default template of these notices, but if it is used, a wrong basket may be passed to generate the notice. This has been caught by a test failure after bug 26745. # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=53] at /kohadevbox/koha/C4/Letters.pm line 679 This is a quick patch to fix the failing test, but more work would needed. We are removing the basket info from those 2 notices and keeping it only for orderacquisition. Technically: the $externalid is coming from the parameter list of SendAlerts, but it is a basketno only for orderacquisition. We must not pass it for other notices. Test plan: Confirm that the failing test is now passing and that the changes make sense. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898 [Bug 21898] Add basket info available for ACQORDER -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 [Bug 28824] Errant variable declaration in C4::Letters -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org