[Bug 29504] New: Confirm Item Parts requires Force Checkout permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Bug ID: 29504 Summary: Confirm Item Parts requires Force Checkout permission Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com With bug 25261, CircConfirmItemParts system preference was added, which is highly popular with libraries. However, it requires staff to have the permission "Force checkout if a limitation exists (force_checkout)". This is a permission that many staff do not have. When a staff member without the Force permission attempts to checkout an item with a 952$3, they get a yellow box stating: Please confirm checkout Please confirm that the accompanying materials are present: check for 12 CDs The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. To replicate: 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25261 CC| |jonathan.druart+koha@gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 [Bug 25261] Multiple parts handling - confirmation alert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I was under the impression force_checkout was only for restrictions on the account. Maybe this should be made more similar to how "Override blocked renewals"? Or can we assume that this should never block a checkout but only force staff to check for completeness and confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Confirm Item Parts requires |Confirm item parts requires |Force Checkout permission |force_checkout permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #2 from Donna <bwsdonna@gmail.com> ---
From talking with libraries, the thought is that it should never block a checkout, but make staff pause to verify parts and then either confirm so the item is checked out, or decline, and the item does not get checked out.
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Donna from comment #2)
From talking with libraries, the thought is that it should never block a checkout, but make staff pause to verify parts and then either confirm so the item is checked out, or decline, and the item does not get checked out.
Thx Donna, that's what I was thinking too. So maybe it's just about removing the check? Adding Martin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- I agree this should not have been a blocker. It is only meant to grab attention to details. Having it block is a blocker itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127926&action=edit Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed The additional materials check when CircConfirmParts is enabled was errantly relying upon the 'FORCE_CHECKOUT' permission. This patch updates the template to allow confirmation as well as cancellation of chekout. Test plan 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 5. The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. 6. Apply patch 7. Repeat step 4. 8. You should now have the option to 'Yes, check out (Y)' or 'No, don't check out (N)' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- There are no string changes here, just template logic fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Batch checkout is broken as well for 'ADDITIONAL_MATERIALS'. I've tried to fix it but it's not trivial, and I think this patch is impacted by the same problem. You can have ADDITIONAL_MATERIALS AND another flags, in that case you shouldn't be allowed to bypass. We need to test that ADDITIONAL_MATERIALS is the only flag that needs a confirmation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Martin, did you see my comment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I did, but I haven't had a moment to come back to work on this again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The same issue is present with HIGHHOLDS then right.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127926|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128549&action=edit Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed The additional materials check when CircConfirmParts is enabled was errantly relying upon the 'FORCE_CHECKOUT' permission. This patch updates the template to allow confirmation as well as cancellation of chekout. Test plan 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 5. The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. 6. Apply patch 7. Repeat step 4. 8. You should now have the option to 'Yes, check out (Y)' or 'No, don't check out (N)' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128550&action=edit Bug 29504: (follow-up) Account for other blockers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My attempt at a fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My attempt at a fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128549|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 130187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130187&action=edit Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed The additional materials check when CircConfirmParts is enabled was errantly relying upon the 'FORCE_CHECKOUT' permission. This patch updates the template to allow confirmation as well as cancellation of chekout. Test plan 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 5. The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. 6. Apply patch 7. Repeat step 4. 8. You should now have the option to 'Yes, check out (Y)' or 'No, don't check out (N)' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128550|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 130188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130188&action=edit Bug 29504: (follow-up) Account for other blockers Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA test tools fail: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/Branches.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. Can you also check Jonathan's comment on batch checkouts please? Should we also be testing batch checkouts here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Resetting status, looks like something is wrong with master or my dev setup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What about batch checkouts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #20 from Kelly McElligott <kelly@bywatersolutions.com> --- *** Bug 30448 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30995 [Bug 30995] Bug 29504 - Confirm item parts requires force_checkout permission (batch checkout) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Confirm item parts requires |Confirm item parts requires |force_checkout permission |force_checkout permission | |(checkouts tab) --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tested the batch checkout and Joubu is right, it doesn't work. The button to perform the checkouts is missing, but it's there when testing with a superlibrarian. My suggestion would be to still have this fix and report/fix the batch checkout feature separately to get this moving again: Bug 30995 - Bug 29504 - Confirm item parts requires force_checkout permission (batch checkout) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130187|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136330&action=edit Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed The additional materials check when CircConfirmParts is enabled was errantly relying upon the 'FORCE_CHECKOUT' permission. This patch updates the template to allow confirmation as well as cancellation of chekout. Test plan 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 5. The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. 6. Apply patch 7. Repeat step 4. 8. You should now have the option to 'Yes, check out (Y)' or 'No, don't check out (N)' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130188|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136331&action=edit Bug 29504: (follow-up) Account for other blockers Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Katrin, much appreciated. I'm not sure how to handle the batch option honestly.. hopefully something will dawn on me later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.03 |22.11.00, 22.05.03, released in| |21.11.11 --- Comment #27 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Version(s)|22.11.00, 22.05.03, |22.11.00, 22.05.03, released in|21.11.11 |21.11.11, 21.05.17 Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.17 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org