[Bug 8760] New: Phone number Field tags are reversed in patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Priority: P5 - low Change sponsored?: --- Bug ID: 8760 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Phone number Field tags are reversed in patron record Severity: normal Classification: Unclassified OS: All Reporter: jesse@bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Patrons Product: Koha Created attachment 12139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12139&action=edit Screen Shoot Phone number Field tags are reversed in patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 --- Comment #1 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 12140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12140&action=edit Screen Shoot 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 --- Comment #2 from Joel Sasse <jsasse@plumcreeklibrary.net> --- Created attachment 24722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24722&action=edit Patron data in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 --- Comment #3 from Joel Sasse <jsasse@plumcreeklibrary.net> --- Created attachment 24723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24723&action=edit Patron data in the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 --- Comment #4 from Joel Sasse <jsasse@plumcreeklibrary.net> --- Created attachment 24724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24724&action=edit Patron data in the database schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 --- Comment #5 from Joel Sasse <jsasse@plumcreeklibrary.net> --- I've attached some additional screenshots highlighting this issue. These mismatched labels cause confusion when processing patron requests for modifications to their personal details. Also, why do the three values each have a different variable type in the database? Phone is text, mobbile is varchar, and fax is mediumtext. Is there a reason for this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 --- Comment #6 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 26184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26184&action=edit Adjusted fields to display correctly. Now the fields on the memberentry page match the memberdetails page. To test: Select a patron account that you can edit their phone number information Fill in all 3 phone number fields: Primary phone: #1 Secondary phone: #2 Other phone: #3 Then view the member details page. This will display #1,#3,#2. Apply patch and should display correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26184|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26190&action=edit [SIGNED-OFF] Bug 8760 - Phone number Field tags are reversed in patron record Adjusted fields to display correctly. Now the fields on the memberentry page match the memberdetails page. To test: Select a patron account that you can edit their phone number information Fill in all 3 phone number fields: Primary phone: #1 Secondary phone: #2 Other phone: #3 Then view the member details page. This will display #1,#3,#2. Apply patch and should display correctly. http://bugs.koha-community.org/show_bug.cgi?id=8760 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |jesse@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26190|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26215&action=edit Bug 8760 - Phone number Field tags are reversed in patron record Adjusted fields to display correctly. Now the fields on the memberentry page match the memberdetails page. To test: Select a patron account that you can edit their phone number information Fill in all 3 phone number fields: Primary phone: #1 Secondary phone: #2 Other phone: #3 Then view the member details page. This will display #1,#3,#2. Apply patch and should display correctly. http://bugs.koha-community.org/show_bug.cgi?id=8760 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- I'm not convinced that this is the correct fix. After applying the patch, if you enter the following in the phone fields: primary: "primary" secondary: "secondary' other: "mobile" while the staff-side patron display is consistent, the OPAC display is not: Primary phone: primary Secondary phone: mobile Mobile phone: secondary and the database gets populated like this: MariaDB [koha]> select phone, phonepro, mobile from borrowers where borrowernumber = 12092\G *************************** 1. row *************************** phone: primary phonepro: mobile mobile: secondary Consequently, I think that it's members/moremember.tt that needs to be corrected (and perhaps "Mobile" should be used as the label rather than "Other"?) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |m.de.rooy@rijksmuseum.nl Resolution|--- |DUPLICATE --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- *** This bug has been marked as a duplicate of bug 12407 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org