[Bug 24406] New: Remove patron category category type codes from patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Bug ID: 24406 Summary: Remove patron category category type codes from patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the patron search, the category type of a patron will show after the patron category description. Example: Student (A) This is confusing as those codes (A = Adult) show nowhere else in the staff interface and can't be easily translated by people using the English templates, but have even less meaning for people using translated templates. I suggest to remove them as I always end up explaining this in training and it's not really useful information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124080&action=edit Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think a span would be the easiest to agree to, but I don't really feel like it's the best possible solution. Owen or others, maybe you got a better idea? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124080|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 125989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125989&action=edit Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #2)
I think a span would be the easiest to agree to, but I don't really feel like it's the best possible solution.
Owen or others, maybe you got a better idea?
I've signed off as it is currently. Happy to sign off again if others have a better idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125989|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127151&action=edit Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch that provides a suitable work around.. It would be nice to see another bug reported to do a nicer job of allowing conversion of these type codes to translatable descriptions. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The patron category type release notes| |code (A, C, O, ...) is | |currently displayed in the | |patron module search, | |patron card creator, and | |acquisition patron | |searches. | | | |This information | |is not useful for most | |users, as these are | |internal codes that cannot | |be easily "decoded". And | |while you might be able to | |guess A as Adult in | |English, it doesn't | |translate to other | |languages. | | | |This patch | |wraps a span around the | |patron category type code | |shown in () after the | |patron category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove patron category |Add a span to patron |category type codes from |category category type |patron search results |codes in patron search | |result lists -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org