[Bug 26149] New: Remove jquery.checkboxes plugin from problem reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Bug ID: 26149 Summary: Remove jquery.checkboxes plugin from problem reports page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 26006 The OPAC problem reports page in the staff interface includes the jquery.checkboxes plugin but doesn't use it. It can be removed without any JS code changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107849&action=edit Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108125&action=edit Bug 26194: Add link to cash register management from message about missing registers In places where the interface warns the user about missing cash registers we should provide users with permission a direct link to the cash register management page. To test, apply the patch and enable the UseCashRegisters and EnablePointOfSale preferences. If necessary, go to Administration -> Cash registers and remove any cash registers for your library. - Log in to the staff interface as a user with "manage_cash_registers" permission. - Locate a patron who has outstanding fines. - Under Accounting -> Make a payment, click the "Pay" button next to a fine. - The page should show the message about missing cash registers with a button which take you directly to the "Add new cash register" form. - Perform the same check by selecting the checkbox next to a fine and clicking the "Pay amount" button and the "Pay selected" button. - Test the message shown at: - Tools -> Cashup registers. - Point of sale -> Register details - Point of sale -> Library details - Perform the same tests when logged in as a user without permission to manage cash registers. The messages shown in the previous steps should omit the button linking to cash register management. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108126&action=edit Bug 26194: (follow-up) Default to current branch When adding a new register, it would be helpful to default to the current logged in branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #108125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug number typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107849|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108129&action=edit Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No regressions.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108129|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108312&action=edit Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org