[Bug 26063] New: Use Koha::Plugins->call for circulation hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Bug ID: 26063 Summary: Use Koha::Plugins->call for circulation hooks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 24031 introduced the handy method and we should use it instead of using in-place helpers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24031 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 [Bug 24031] Add plugin hook after_hold_create -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107366&action=edit Bug 26063: Use Koha::Plugins->call for circulation hooks This patch gets rid of a helper method used for calling the plugin hooks. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25961 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25961, 25855 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not apply on top of 24031 Applying: Bug 26063: Use Koha::Plugins->call for circulation hooks error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26063: Use Koha::Plugins->call for circulation hooks Neither on top of the PQA hook related patch. Please build this on top of bug 25961, bug 25855 and bug 24031. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 [Bug 25961] Add hooks for plugins to inject variables to XSLT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 [Bug 21468] Plugins need hooks for checkin and checkout actions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Fixed the dependencies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tomas, I thought that the plan was to use Koha::Plugins->call everywhere. This patch is only using it for circulation hooks. Can we have a plan for that as well please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107498&action=edit Bug 26063: Use Koha::Plugins->call for some other hooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use Koha::Plugins->call for |Use Koha::Plugins->call for |circulation hooks |other hooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Are there other hooks not covered? (I did not test this last patch!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107498|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107561&action=edit Bug 26063: Use Koha::Plugins->call for some other hooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107561|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107562&action=edit Bug 26063: Use Koha::Plugins->call for some other hooks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107595&action=edit Bug 26063: Use Koha::Plugins->call for circulation hooks This patch gets rid of a helper method used for calling the plugin hooks. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107596&action=edit Bug 26063: Use Koha::Plugins->call for some other hooks Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26108 [Bug 26108] Checkins should not require item to have been checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26108 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26108 [Bug 26108] Checkins should not require item to have been checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Has anyone tested this without a plugin installed? I tried to do an OPAC search on a fresh install of master and I'm getting errors. Can't use string ("0") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/opac/opac-search.pl line 661 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26138 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138 [Bug 26138] Errors if enable_plugins is zero -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I have opened Bug 26138 as this patch causes a bug when enable_plugins is 0. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org