[Bug 3169] New: Google Jackets Display Issues
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 Summary: Google Jackets Display Issues Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: minor Priority: P5 Component: OPAC AssignedTo: jmf@liblime.com ReportedBy: nicole.engard@liblime.com CC: oleonard@myacpl.org Estimated Hours: 0.0 Created an attachment (id=761) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=761) search results See my screenshots. On the search results with Google Jackets turned on - the jacket image overlaps a text link that says 'source google' On the detail page - there is a link that says Source Google - but it doesn't explain that the jacket is all that link refers to - why are we putting a text link there instead of a link on the Jacket itself? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 --- Comment #1 from Nicole C. Engard <nicole.engard@liblime.com> 2009-04-28 13:09:20 --- Created an attachment (id=762) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=762) detail page -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 frederic@tamil.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr AssignedTo|jmf@liblime.com |frederic@tamil.fr --- Comment #2 from frederic@tamil.fr 2009-04-28 18:12:43 ---
See my screenshots. On the search results with Google Jackets turned on - the jacket image overlaps a text link that says 'source google'
Thanks for your vigilance. I've introduced that: http://tinyurl.com/dh79dx I apologize for the overlap and will fix it if you want.
On the detail page - there is a link that says Source Google - but it doesn't explain that the jacket is all that link refers to - why are we putting a text link there instead of a link on the Jacket itself?
It was working as you say before my patch... A click on jacket were redirecting to Google Book page. But I have been asked by librarians to change that in order to advice readers that a link to Google Books was available at all. I've also seen this implementation in a lot of other ILS OPAC. So two solutions: 1. Ask Galen to revert my patch to get back the prevous implementation. 2. Let me correct the display issue. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 Nicole C. Engard <nicole.engard@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |galen.charlton@liblime.com --- Comment #3 from Nicole C. Engard <nicole.engard@liblime.com> 2009-04-28 19:33:14 --- We don't say that the cover images come from Amazon or Syndetics in the OPAC - do we? So why say it's from Google? I say we put it back the way it was ... but I'll wait to hear from the others. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 --- Comment #4 from frederic@tamil.fr 2009-05-06 15:59:41 ---
We don't say that the cover images come from Amazon or Syndetics in the OPAC - do we? So why say it's from Google? I say we put it back the way it was ... but I'll wait to hear from the others.
http://code.google.com/intl/en/apis/books/branding.html I read that this button is required: http://www.google.com/intl/en/googlebooks/images/gbs_preview_button1.png -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 Joe Atzberger <joe.atzberger@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joe.atzberger@liblime.com --- Comment #5 from Joe Atzberger <joe.atzberger@liblime.com> 2009-05-06 17:02:49 --- (In reply to comment #4)
We don't say that the cover images come from Amazon or Syndetics in the OPAC - do we? So why say it's from Google? I say we put it back the way it was ... but I'll wait to hear from the others.
http://code.google.com/intl/en/apis/books/branding.html
I read that this button is required:
http://www.google.com/intl/en/googlebooks/images/gbs_preview_button1.png
That guideline is newer than the GBS implementation. If I recall correctly, the old guidelines were less concrete, only demanding attribution, which we gave with the simple text link. And that button has english text in it. So what they really mean is include one of the dozen translated buttons: http://code.google.com/intl/en/apis/books/examples/translated-branding-eleme... Annoying! -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 --- Comment #6 from Nicole C. Engard <nicole.engard@liblime.com> 2009-05-08 14:02:38 --- I agree it's annoying - but I also think that the buttons are at least a bit clearer than the text saying that the source is from Google Books - cause 'source' doesn't imply that it's the jacket that's from Google. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 --- Comment #7 from Galen Charlton <galen.charlton@liblime.com> 2009-05-13 14:11:42 --- Pushed Frederic's patch. I think a little CSS work may be needed so that the book cover doesn't overlap with the Google preview button, and additional work will be needed to get this internationalized. It may be just me, but while I don't mind the Google preview image in the bib details page, it's distracting in the search results. On the other hand, I'm not sure that I can came up with a reading of the Google TOS that allows displaying that button only on the bib details page. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 --- Comment #8 from Nicole C. Engard <nicole.engard@liblime.com> 2009-05-18 22:47:42 --- It's not you - it's very distracting to me on the search results as well. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 --- Comment #9 from frederic@tamil.fr 2009-05-23 06:45:50 --- I sent a patch that removes google button on result page and keep it on detail page. It wouldn't be a big deal to enable it back if required explicitly by Google. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 --- Comment #10 from Galen Charlton <galen.charlton@liblime.com> 2009-05-27 12:20:32 --- (In reply to comment #9)
I sent a patch that removes google button on result page and keep it on detail page. It wouldn't be a big deal to enable it back if required explicitly by Google.
Pushed patch to HEAD. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3169 Nicole C. Engard <nicole.engard@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠liblime.com