https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 190753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190753&action=edit Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. To reproduce: 1. Add or modify existing circulation rule and set Expired hold charge value as 1.30. 2. Edit the rule you just created or modified. => Note that Expired hold charge is not displayed. => When saving the rule note that Expired hold charge is now overwritten with blank value. 3. Apply this patch. 4. Set Expired hold charge value as 1.30. 5. Edit the rule. => Note that Expired hold charge is now displayed correctly. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190753|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 192526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192526&action=edit Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. To reproduce: 1. Add or modify existing circulation rule and set Expired hold charge value as 1.30. 2. Edit the rule you just created or modified. => Note that Expired hold charge is not displayed. => When saving the rule note that Expired hold charge is now overwritten with blank value. 3. Apply this patch. 4. Set Expired hold charge value as 1.30. 5. Edit the rule. => Note that Expired hold charge is now displayed correctly. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, I was able to confirm the problematic behavior, but there is still a tiny problem: When CurrencyFormat is set to FR, the value on editing will contain the comma, creating an invalid input format. I believe we fixed this in other spots - could you have a look? -- You are receiving this mail because: You are watching all bug changes.