[Bug 41500] New: Expired hold charge value containing decimal with fraction dropped when editing a rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Bug ID: 41500 Summary: Expired hold charge value containing decimal with fraction dropped when editing a rule Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. To reproduce: 1. Add or modify existing circulation rule and set Expired hold charge value as 1.30. 2. Edit the rule you just created or modified. => Note that Expired hold charge is not displayed. => When saving the rule note that Expired hold charge is now overwritten with blank value. 3. Edit the rule again and set Expired hold charge value as 1.00. 4. Now edit rule again. => Note that Expired hold charge is now displayed as expected and saving doesn't overwrite the value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 190753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190753&action=edit Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. To reproduce: 1. Add or modify existing circulation rule and set Expired hold charge value as 1.30. 2. Edit the rule you just created or modified. => Note that Expired hold charge is not displayed. => When saving the rule note that Expired hold charge is now overwritten with blank value. 3. Apply this patch. 4. Set Expired hold charge value as 1.30. 5. Edit the rule. => Note that Expired hold charge is now displayed correctly. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- This needs some more work so that 0 value doesn't empty field when row is modified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190753|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 192526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192526&action=edit Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. To reproduce: 1. Add or modify existing circulation rule and set Expired hold charge value as 1.30. 2. Edit the rule you just created or modified. => Note that Expired hold charge is not displayed. => When saving the rule note that Expired hold charge is now overwritten with blank value. 3. Apply this patch. 4. Set Expired hold charge value as 1.30. 5. Edit the rule. => Note that Expired hold charge is now displayed correctly. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, I was able to confirm the problematic behavior, but there is still a tiny problem: When CurrencyFormat is set to FR, the value on editing will contain the comma, creating an invalid input format. I believe we fixed this in other spots - could you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #4)
Hi Emmi,
I was able to confirm the problematic behavior, but there is still a tiny problem: When CurrencyFormat is set to FR, the value on editing will contain the comma, creating an invalid input format.
I believe we fixed this in other spots - could you have a look?
This happens because Expired hold charge field matches input value against pattern "^\d+(\.\d{2})?$". All fields allowing decimals behave same way, e.g. Overdue fines cap (amount). If dot is changed to comma, decimals with dot separator are invalid. I'd say fixing this is not in the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #5)
(In reply to Katrin Fischer from comment #4)
Hi Emmi,
I was able to confirm the problematic behavior, but there is still a tiny problem: When CurrencyFormat is set to FR, the value on editing will contain the comma, creating an invalid input format.
I believe we fixed this in other spots - could you have a look?
This happens because Expired hold charge field matches input value against pattern "^\d+(\.\d{2})?$". All fields allowing decimals behave same way, e.g. Overdue fines cap (amount). If dot is changed to comma, decimals with dot separator are invalid. I'd say fixing this is not in the scope of this bug.
Tested again (I should really triple check my tests) and without patch editing works fine. I'll see what has been broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #6)
(In reply to Emmi Takkinen from comment #5)
(In reply to Katrin Fischer from comment #4)
Hi Emmi,
I was able to confirm the problematic behavior, but there is still a tiny problem: When CurrencyFormat is set to FR, the value on editing will contain the comma, creating an invalid input format.
I believe we fixed this in other spots - could you have a look?
This happens because Expired hold charge field matches input value against pattern "^\d+(\.\d{2})?$". All fields allowing decimals behave same way, e.g. Overdue fines cap (amount). If dot is changed to comma, decimals with dot separator are invalid. I'd say fixing this is not in the scope of this bug.
Tested again (I should really triple check my tests) and without patch editing works fine. I'll see what has been broken.
Welp, this part; else if (current_input_id === "expire_reserves_charge"), is totally useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192526|0 |1 is obsolete| | --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 203334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203334&action=edit Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. To reproduce: 1. Add or modify existing circulation rule and set Expired hold charge value as 1.30. 2. Edit the rule you just created or modified. => Note that Expired hold charge is not displayed. => When saving the rule note that Expired hold charge is now overwritten with blank value. 3. Apply this patch. 4. Set Expired hold charge value as 1.30. 5. Edit the rule. => Note that Expired hold charge is now displayed correctly. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Removed useless code. This should now work with all CurrencyFormat settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Emmi Takkinen from comment #9)
Removed useless code. This should now work with all CurrencyFormat settings.
I'll try to retest as soon as I can, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Comma delimited| |Koha-Suomi Oy list of Sponsors| | Sponsorship status|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41500 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 203384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203384&action=edit Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. To reproduce: 1. Add or modify existing circulation rule and set Expired hold charge value as 1.30. 2. Edit the rule you just created or modified. => Note that Expired hold charge is not displayed. => When saving the rule note that Expired hold charge is now overwritten with blank value. 3. Apply this patch. 4. Set Expired hold charge value as 1.30. 5. Edit the rule. => Note that Expired hold charge is now displayed correctly. Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org