[Bug 5335] New: More granular VAT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Summary: More granular VAT Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Better_VAT_RFC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Deadline: 2011-05-01 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2010-11-02 02:31:22 UTC --- More granular VAT (all) Sponsored by St Etienne University and developed by BibLibre, expected for/deadline: 2011-05-01 bugzilla entry: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 [edit] Description the available vats will be a syspref (5.5%, 19.6% in france for example). each supplier will have a default vat value, but for each order line the librarian will be able to choose the vat to apply. all prices & totals will be displayed VATs excluded and VATs included where applicable in basket & parcel management on parcel management, it will be possible to modify the applied VAT rate -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2010-11-02 03:21:05 UTC --- *** Bug 5350 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7163 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-05 10:53:48 UTC --- If you want to participate to the upstreaming: * assign the bug to yourself * retrieve the patch(es) on git.biblibre.com * the branch name can be found using git branch -a|grep NNNN Usually, it should be biblibre/customer/ft/MTNNNN For example: remotes/origin/stetienne/ft/MT6522 This patch is in branch number 5836 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Change sponsored?|--- |Sponsored AssignedTo|henridamien@koha-fr.org |claire.hernandez@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m AssignedTo|claire.hernandez@biblibre.c |jonathan.druart@biblibre.co |om |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7180 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@biblib | |re.com --- Comment #4 from Francois Charbonnier <francois.charbonnier@biblibre.com> --- Here (http://wiki.koha-community.org/wiki/Better_VAT_RFC), you will find more information about how this development works. If you need more details, tell me! (francharb on IRC) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8390&action=edit Bug 5335 More granular VAT See the wiki page for more information -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tredok.pierre@gmail.com --- Comment #6 from Pierre Angot <tredok.pierre@gmail.com> --- Test on sandbox. There is a problem with ordering. I've created a basket and add an order. Two columns of the "Order details" aren't fill (cf 5335_order.png). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #7 from Pierre Angot <tredok.pierre@gmail.com> --- Created attachment 8406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8406&action=edit screenshot about bug 5335 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't know why, updatedatatable script was not execute on your sandbox. I have execute it manually (it creates aqorders.discount and renames aqorders.gst with aqorders.gstrate). Can you please retest in test8 ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Pierre Angot <tredok.pierre@gmail.com> --- It's ok. Maybe someone can make an other test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Pierre Angot <tredok.pierre@gmail.com> --- First : we can't select TVA (no "Accounting Details") when add order from a staged file. Second : added an order from staged files, price are not correct. Sandbox8, basket N°5 an 7. We used this file : 146498lecannetdesmaures.mrc (batch 224). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8390|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8488&action=edit Bug 5335 More granular VAT Rebased patch and adapts acqui/addorderiso2709.pl script -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Pierre Angot <tredok.pierre@gmail.com> --- It works ! \o/ Test on a sandbox (Unimarc). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8406|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- this patch does not apply anymore, and solving conflict is not trivial, sorry :\ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7175 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7175 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8488|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8873&action=edit Bug 5335 More granular VAT Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I am sorry, this is conflicting again and I am not sure how to solve it. Can you perhaps rebase again? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8873|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8902&action=edit Bug 5335 More granular VAT Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8902|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9171&action=edit Bug 5335 More granular VAT Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch is already signed off by Pierre but another signer is welcome :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9171|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9586&action=edit Bug 5335 More granular VAT Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> --- conflict again = CONFLICT (content): Merge conflict in C4/Acquisition.pm Auto-merging acqui/finishreceive.pl CONFLICT (content): Merge conflict in acqui/finishreceive.pl Auto-merging acqui/orderreceive.pl CONFLICT (content): Merge conflict in acqui/orderreceive.pl Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl This patch is quite large, I fear it will conflict a lot. If it has been signed-off by Pierre already, as it's a dev that is in production for one BibLibre customer, I think it's OK to mark it "signed-off" once you've rebased it. [Katrin, if you can test it quickly, you'll be more than welcomed ;-) ] (and I'll test once again before pushing) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9586|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9754&action=edit Rebased patch BZ5335: More granular VAT signed-off-by: Pierre Angot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9754|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9970&action=edit Rebased patch Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #23 from Marc Véron <veron@veron.ch> --- Katrin and I found a bug while testing the patch during Kohacon 12 Hackfest. If you add new items to a basket, the form "Item" is rpeated several times. We double checked with and without patch applied and with and without ACQ framework defined. Additionally, in the Items list table we had a line missing between the first and the second item. See screenshot attached. ---------------- We found a misspelling in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref If you want more than 1 value, please separe with |) should read If you want more than 1 value, please separate with |) ---------------- We found several Bugs on Bugzilla that probably could be related to or resolved by this one: Bug 7495 - Tax calculations problem for new orders. Bug 7686 - Tax rate wrong calculation in reception summary page Bug 6965 - Tax and dicount rate should be formatted the same Bug 3980 - Vendor GST being ignored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #24 from Marc Véron <veron@veron.ch> --- Created attachment 10017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10017&action=edit Screenshot of duplicated form -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #25 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Apart from the bugs reported by Marc, I found a blocking bug too. Showing a basket (cgi-bin/koha/acqui/basket.pl?basketno=xxx) produces a software error: Software error: Undefined subroutine &main::get_infos called at /home/koha/versions/kohacommunity/acqui/basket.pl line 272. Of course, it does not happen without the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #26 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- About the items repetion, javascript fails on the page because a call function called calcNeworderTotal is triggered but never defined. That causes entered items fields never to be hidden. Hence the repetition. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9970|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10148&action=edit Rebased patch Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #28 from Pierre Angot <tredok.pierre@gmail.com> --- I've noticed a problem with the columns when I've saved a basket. They are shifted (cf bug_table.png). Test on sandbox 1. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #29 from Pierre Angot <tredok.pierre@gmail.com> --- Created attachment 10159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10159&action=edit bug with columns -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Pierre, I can't reproduce your problem, could you explain the procedure to reproduce please ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #31 from Pierre Angot <tredok.pierre@gmail.com> --- Nothing spécial ^^ - manage suggest - create basket - add an order line from suggest I have tested with Chromium. No problem with Firefox. Maybe a bug with Chromium ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- Pierre, I have tested with FF >= 3.6 and chromium v.20 and the display is correct. Could you update your browser and retest please ? It seems there is a bug when we hide the th elements. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #33 from Pierre Angot <tredok.pierre@gmail.com> --- Yep, that's what I wanted to do. But, I've got a big problem with my Ubuntu (10.04 -> 12.04 = crash). Many paquets are corrupted, and I can't upgrade anything ^^ I'll test thursday on (?) an other install. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7686 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7495 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6965 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10148|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10400&action=edit Rebased patch BZ5335: More granular VAT signed-off-by: Pierre Angot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10400|0 |1 is obsolete| | --- Comment #35 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10781&action=edit BZ5335: More granular VAT signed-off-by: Pierre Angot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #36 from Chris Cormack <chris@bigballofwax.co.nz> --- Rebased to fix updatedatabase conflict -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10781|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11332&action=edit BZ5335: More granular VAT signed-off-by: Pierre Angot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11332|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #39 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 11351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11351&action=edit BZ5335: More granular VAT signed-off-by: Pierre Angot Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #40 from Pierre Angot <tredok.pierre@gmail.com> --- Created attachment 11352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11352&action=edit screenshots about some tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #41 from Pierre Angot <tredok.pierre@gmail.com> --- I've made some new tests. syspref gist : 0.1|0.196|0.05|0.07 I've created 2 vendors : one with discount and one without. - basket 1 : no discount, default tax rate 10%, add order with different VAT (5%) - basket 2 : 2% discount. Need to test list prices and invoices prices. New vendor. - basket 4 : tax rate = 10%, no discount, list prices and invoice prices include tax. - basket 5 : tax rate = 10%, no discount, invoice prices include tax. - basket 6 : tax rate = 10%, no discount, list prices include tax. Theses baskets have also an ACQ framework. You can check calculations (correct words ?) with the screenshots ("screenshots about some tests" : 1 zip, 4 files). I haven't noticed any problems. Test on sandbox. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5343 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11351|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11662&action=edit Bug 5335 - More granular VAT Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #43 from Larry Baerveldt <larry@bywatersolutions.com> --- Created attachment 11668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11668&action=edit Bug 5335 - More granular VAT Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #44 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 11669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11669&action=edit Bug 5335 - More granular VAT Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11662|0 |1 is obsolete| | Attachment #11668|0 |1 is obsolete| | Attachment #11669|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12340&action=edit Bug 5335 - More granular VAT Rebased patch (conflicts no easy to solved, please test while making QA) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl * a big patch, but not so much code. A lot is made of cleaning / change in indentation/... like - $line{booksellerid} = $booksellerid; + $line{booksellerid} = $booksellerid; * I'm not sure the following change - $biblionumber, $ordernumber, $quantityrec, $user, $unitprice, - $invoiceid, $replacement, undef, $datereceived, \@received_items); + $biblionumber, + $ordernumber, + $quantityrec, + $user, + $order->{unitprice}, + $order->{ecost}, + $invoiceno, + $order->{rrp}, + undef, + $datereceived, + \@received_items, + ); is very desirable, but I won't fail QA for that * I'm not sure that t/db_dependent/lib/KohaTest/* is used, so the (tiny) changes here are probably useless. Conclusion = Passed QA ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master I made a very intensive testing of this patch, and could not find any problem either. 3 other signoffs... patch pushed ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #48 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 8788 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8832 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul, can you please take a look at 8832? We found a bigger problem that was introduced by this feature. Thx! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #50 from Nicole C. Engard <nengard@gmail.com> --- Due to bug 8832 we think this patch needs to be reverted and thought out a bit more for the worldwide community. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #50)
Due to bug 8832 we think this patch needs to be reverted and thought out a bit more for the worldwide community.
Agreed. Nobody realized what ramifications this patch would cause. We need to revert it until an upgrade patch can be found and added. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #52 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Patch breaks subscription-detail.pl ( it calls non-existant subroutines GetLastOrderNotReceivedFromSubscriptionId and GetLastOrderReceivedFromSubscriptionId it also does not put brackets around the parameters for these generating another error -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #53 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #52)
Patch breaks subscription-detail.pl ( it calls non-existant subroutines GetLastOrderNotReceivedFromSubscriptionId and GetLastOrderReceivedFromSubscriptionId
Yikes ! This sub is here since the 1st patch submitted, it seems that no-one spotted that subscription-detail.pl was changed, and this patch has 4 signoffs+ my tests !!! * I've digged, and can't find any reference to this sub anywhere outside from subscription-detail.pl * it's used to display a link from subscription to acquisitions when applicable * Jonathan is not here atm (holiday for 2 more weeks) * I don't want to revert this patch, because reverting an updatedatabase-d patch is a nightmare To fix the problem described, I've commented the lines calling those sub. The behaviour on subscription is back to normal. I'll push this problem on top of Jonathan's list when he comes back. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #53)
(In reply to comment #52)
Patch breaks subscription-detail.pl ( it calls non-existant subroutines GetLastOrderNotReceivedFromSubscriptionId and GetLastOrderReceivedFromSubscriptionId
To fix the problem described, I've commented the lines calling those sub. The behaviour on subscription is back to normal. I'll push this problem on top of Jonathan's list when he comes back.
I think it is the best way to fix it. In fact these 2 routines will be add by the Bug 5343 and should not be present with this patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|More granular VAT |define VAT/taxes at | |order-line level, with | |default value for supplier | |and list of valid tax rates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|define VAT/taxes at |define VAT/taxes at |order-line level, with |orderline level, with |default value for supplier |default value for supplier |and list of valid tax rates |and list of valid tax rates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9506 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 5173 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shinoy.m@osslabs.biz --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 8343 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org