[Bug 12143] New: hiding alternate address on patron self registration doesn't hide heading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Bug ID: 12143 Summary: hiding alternate address on patron self registration doesn't hide heading Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org In the OPAC when on the self registration form if you have hidden all of the alternate address fields the heading for that section still shows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 --- Comment #1 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 29164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29164&action=edit Bug 12143 - hiding alternate address on patron self registration doesn't hide heading This patch fixes the following issue: in OPAC self registration form, even if all alternate address fields are configured as hidden, the heading for "Alternate address" still shows. To test: 1/ Confirm the issue: hide all alternate adres field names (i.e., enter B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField system prefrence). 2/ Observe that "Alternate address" section heading still shows in patron self registration form ("your personal details" tab), despite that all section fields are configured as hidden. 3/ Apply patch. 4/ Reload OPAC self registration form; confirm that "Alternate address" is not displyed any longer, and the issue is now fixed. 5/ Remove some field name (e.g. B_address2) from PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate address" heading does show if at least one section field is not hidden. 6/ Test steps 1-5 should be performed/repeated in both bootstrap and prog OPAC themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl Version|3.14 |master Assignee|oleonard@myacpl.org |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29164|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 29170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29170&action=edit Bug 12143 - hiding alternate address on patron self registration doesn't hide heading This patch fixes the following issue: in OPAC self registration form, even if all alternate address fields are configured as hidden, the heading for "Alternate address" still shows. To test: 1/ Confirm the issue: hide all alternate adres field names (i.e., enter B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField system prefrence). 2/ Observe that "Alternate address" section heading still shows in patron self registration form ("your personal details" tab), despite that all section fields are configured as hidden. 3/ Apply patch. 4/ Reload OPAC self registration form; confirm that "Alternate address" is not displyed any longer, and the issue is now fixed. 5/ Remove some field name (e.g. B_address2) from PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate address" heading does show if at least one section field is not hidden. 6/ Test steps 1-5 should be performed/repeated in both bootstrap and prog OPAC themes. Followed test plan with prog and bootstrap themes, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29187&action=edit [PASSED QA] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading This patch fixes the following issue: in OPAC self registration form, even if all alternate address fields are configured as hidden, the heading for "Alternate address" still shows. To test: 1/ Confirm the issue: hide all alternate adres field names (i.e., enter B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField system prefrence). 2/ Observe that "Alternate address" section heading still shows in patron self registration form ("your personal details" tab), despite that all section fields are configured as hidden. 3/ Apply patch. 4/ Reload OPAC self registration form; confirm that "Alternate address" is not displyed any longer, and the issue is now fixed. 5/ Remove some field name (e.g. B_address2) from PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate address" heading does show if at least one section field is not hidden. 6/ Test steps 1-5 should be performed/repeated in both bootstrap and prog OPAC themes. Followed test plan with prog and bootstrap themes, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12143 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Simple typo fix, that fixes a nasty bug. Pushed to Master as MM OPAC .. thanks for the patch Jacek -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org