http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31742&action=edit [NOT TO PUSH] Prices and VAT calculation - before This file contains all price values displayed into Koha for all pages and all supplier configurations. It will be very useful for testers and developers and QAers to test/validate other patches. All these values should be kept as it, without any changes during all the refactoring/plumbing process. I would like to get 1 signoff on it. Test plan: Create 4 suppliers (1 for each configuration) and follow the different step of the acquisition workflow. The values you see on the screen should be the same as the ones listed in this file. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31742|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31743&action=edit [NOT TO PUSH] Prices and VAT calculation - before -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #3 from Paola Rossi <paola.rossi@cineca.it> --- I've tested against 3.17.00.025. On the IV - Configuration 4 (0 1), the increasing number of the steps is wrong: 5) has been written twice, and so the file needs to be amended: A) instead of : 5) On the Acquisition home page (acqui-home.pl) this should be written: 6) On the Acquisition home page (acqui-home.pl) B) Instead of: 6) On the Acquisition home page (acqui-home.pl) this should be written: 7) On the Acquisition home page (acqui-home.pl) C) the next line: 7) On the Acquisition home page (acqui-home.pl) has been written in the wrong place and must be cancelled. ------------------------------------ I think that an invoice has had a shipping cost of 5. And that 1 cent made no difference. ------------------------------------ So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #3) Thanks Paola!

On the IV - Configuration 4 (0 1), the increasing number of the steps is wrong: 5) has been written twice, and so the file needs to be amended:

Yes, bad copy and paste at the end. It should be fixed now.

I think that an invoice has had a shipping cost of 5. And that 1 cent made no difference.

I don't understand where is the 1-cent difference. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #6)

Thanks, Jonathan.

I've tested again against master 3.17.00.025, about the 1 cent' differences.

-------------------------------------------------------- II - Configuration 2 (1 1) List item price includes tax Invoice item price includes tax

file-doc says: 7) On the basket group (pdf English 3-page) ... gstvalue = 7.03

but I see: gstvalue = 7.02

Arg, my fault. It is 7.02 in master (but should actually be 7.03). I will fix that.

2) On the basket page (basket.pl rrp_it = 82.01

but I see: rrp_it = 82.00

For the configuration 3, I got 82.01, see the screenshot I will attach. Could you confirm it is 82.00 for you?

I don't know if these differences of 1 cent are so substantial.

Yes, they are :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31843&action=edit basket for conf 3 (1 0) 82.01 vs 82.00 for configuration 3 ( 1 0 ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 --- Comment #10 from Paola Rossi <paola.rossi@cineca.it> --- Thank you, Jonathan. (In reply to Jonathan Druart from comment #7) [...]

...

2) On the basket page (basket.pl rrp_it = 82.01

but I see: rrp_it = 82.00

For the configuration 3, I got 82.01, see the screenshot I will attach. Could you confirm it is 82.00 for you?

The screen you attached is about the 9) step of Conf III (see the rcvd status of the order 57). On the 9) step of Conf III I agreed with the file-doc and saw 82.01 by my side too. No problem here. On the contrary, my old note was about the 2) step of Conf III. And I confirm you that, on the 2) step of Conf III, I see 82.00 instead of the file-doc 82.01. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31842|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31876&action=edit [NOT TO PUSH] Prices and VAT calculation - before -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31876|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31895&action=edit [NOT TO PUSH] Prices and VAT calculation - before -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Paola, you are amazing! Sorry not to be as meticulous as you! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not sure about this one - no patches? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #19)

Moving this out of the queue for now - all other patches are blocked or passed QA.

There is no patch on this one. It's a document to review, see description. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |ASSIGNED --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #20)

There is no patch on this one. It's a document to review, see description.

Suppose we could move the status to ASSIGNED and remove it from the SO queue. It does not belong here. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This was just a doc. Still useful for patches in the queue. -- You are receiving this mail because: You are watching all bug changes.