[Bug 40695] New: Onboarding secretly enforces uppercase branchcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40695 Bug ID: 40695 Summary: Onboarding secretly enforces uppercase branchcodes Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When creating a branch through the web installer onboarding process, Koha enforces uc() on the chosen branchcode in the background, which is not visible to the user in the interface. There is 2 issues with this: * The staff interface doesn't have this limitation. * The user doesn't notice this until they get into Koha later, when a user has already been created with this branchcode. In our case it is problematic because some codes can contain lower case letters for a reason and this is really hard to fix when noticed much later on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40695 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- onboarding.pl uses uc() on both $branchcode and $itemtype_code. Looks like the item type creation process in the staff interface also converts the code to uppercase. So we're being consistent with the handling of item type codes in the backend. If that's really how we want it to work we should make sure the code appears as uppercase during the entry process. categories.pl does this using JavaScript. The staff interface doesn't treat 'BranchCode' and 'BRANCHCODE' as different entities... Koha won't let you create a new branch with a differently-cased code. I think for that reason we should probably use uc() and branch codes like we do with patron category codes and item type codes. What is the reason for wanting lower case as an option? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40695 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We use the ISIL as branchcode since the beginning, as it's a unique identifier for the library and is also used in the MARC records. German ISIL are derived from the pre-existing Sigel for ILL and can contain lower and upper case letters. While SQL doesn't care, whenever the code is compared using Perl or Python, the difference will have comparisons fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org