[Bug 34153] New: Add ability to allow items with additional materials notes to be checked out via SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Bug ID: 34153 Summary: Add ability to allow items with additional materials notes to be checked out via SIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org At this time, any item with an additional materials date is blocked from checkout via SIP with a screen message to take the item to a circulation desk for checkout. Some libraries wish to allow patrons to check out items via SIP even if the item has additional materials. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152864&action=edit Bug 34153: Add ability to allow items with additional materials notes to be checked out via SIP At this time, any item with an additional materials date is blocked from checkout via SIP with a screen message to take the item to a circulation desk for checkout. Some libraries wish to allow patrons to check out items via SIP even if the item has additional materials. Test Plan: 1) Create an item with an additional materials note 2) Attempt to check it out via SIP 3) Note the failure and message 4) Enable the new SIP account option "allow_additional_materials_checkout" 5) Restart the SIP server 6) Attempt the checkout again 7) Note the checkout success and new AF field message! 8) prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Why not use the existing syspref_overrides setting here? With these patches, you get the additional materials note only if both CircConfirmItemParts system preference is enabled and allow_additional_materials_checkout is in the SIP config. I think we should always be adding the additional materials note to the screen msg You can access the Koha item object in the SIP item object - so I don't think we should add a fetch. Possibly we should just add the additional_materials field to the SIP object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- The syspref override is the usual way to handle this, however if they still want a screen message that won't be sufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Liz Rea from comment #3)
The syspref override is the usual way to handle this, however if they still want a screen message that won't be sufficient.
^ This. It provides a screen message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152864|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 155740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155740&action=edit Bug 34153: Add ability to allow items with additional materials notes to be checked out via SIP At this time, any item with an additional materials date is blocked from checkout via SIP with a screen message to take the item to a circulation desk for checkout. Some libraries wish to allow patrons to check out items via SIP even if the item has additional materials. Test Plan: 1) Create an item with an additional materials note 2) Attempt to check it out via SIP 3) Note the failure and message 4) Enable the new SIP account option "allow_additional_materials_checkout" 5) Restart the SIP server 6) Attempt the checkout again 7) Note the checkout success and new AF field message! 8) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Edit an item for a record and add some text to 952$3 (Materials specified (bound volume or other part)) - I added a note to Programming Perl (record #262, barcode 39999000011418). 2. Attempt to check out the item using SIP - item is successfully issued and no message: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron koha -m checkout --item 39999000011418 Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN20230917 05411420230917 054114AOCPL|AAkoha|AB39999000011418|ACterm1|BIN| READ: 121NNY20230917 054114AOCPL|AAkoha|AB39999000011418|AJProgramming Perl /|AH20230922 235900 3. Check in the item. 4. Enable system preference CircConfirmItemParts (set to 'Require'). 5. Attempt to check out the item using SIP - note that the message is 'Item must be checked out at a circulation desk' and the item is not checked out: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron koha -m checkout --item 39999000011418 Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN20230917 06184820230917 061848AOCPL|AAkoha|AB39999000011418|ACterm1|BIN| READ: 120NUN20230917 061848AOCPL|AAkoha|AB39999000011418|AJProgramming Perl /|AH|AFItem must be checked out at a circulation desk|BLY| 6. Apply the patch. 7. Edit /etc/koha/sites/kohadev/SIPconfig.xml and add allow_additional_materials_checkout="1" - line 47 should read: <login id="term1" password="term1" delimiter="|" error-detect="enabled" institution="CPL" encoding="ascii" checked_in_ok="1" allow_additional_materials_checkout="1"/> 8. restart_all 9. Repeat step 5 - should now get a different message 'Item has additional materials: ...', and the item is checked out. ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron koha -m checkout --item 39999000011418 Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN20230917 11150920230917 111509AOCPL|AAkoha|AB39999000011418|ACterm1|BIN| READ: 121NNY20230917 111509AOCPL|AAkoha|AB39999000011418|AJProgramming Perl /|AH20230922 235900|AFItem has additional materials: Text added to item record| -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155920&action=edit Bug 34153: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155740|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155921&action=edit Bug 34153: Add ability to allow items with additional materials notes to be checked out via SIP At this time, any item with an additional materials date is blocked from checkout via SIP with a screen message to take the item to a circulation desk for checkout. Some libraries wish to allow patrons to check out items via SIP even if the item has additional materials. Test Plan: 1) Create an item with an additional materials note 2) Attempt to check it out via SIP 3) Note the failure and message 4) Enable the new SIP account option "allow_additional_materials_checkout" 5) Restart the SIP server 6) Attempt the checkout again 7) Note the checkout success and new AF field message! 8) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor@tuxayo.net QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Split tests in a separate commit to confirm that it indeed fails with the implementation. Code looks good (except tidying work to do), will manually test ASAP Meanwhile there is this to look at and fix: WARN C4/SIP/ILS/Transaction/Checkout.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 58, now: 60) WARN t/db_dependent/SIP/Message.t WARN tidiness The file is less tidy than before (bad/messy lines before: 521, now: 561) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 155927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155927&action=edit Bug 34153: (QA follow-up) Tidy code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for the tidying :) Lol perltidy puts tons of spaces to align $response with 'equals'.
check_field( $respcode, $response, FID_SCREEN_MSG, 'Item must be checked out at a circulation desk', 'Check screen msg', 'equals' );
Should we care? Maybe not, let's continue with the workflow and if someone has more on the .perltidyrc matter, let's create a ticket or email the koha-dev list or something. Last point to settle is whether allow_additional_materials_checkout should be on by default. I don't have an educated enough opinion on this. I sent an email to the rest of the QA team, let's see what comes out.
Hi 🙂
The only thing I need to pass this ticket is to settle on this question. To eventually make a follow-up changing the default config file. (it's currently allow_additional_materials_checkout="1")
I'm leaning a bit towards having it off by default. I suppose libraries would prefer to have to make the conscious decision to trust the patrons to self manage all items having additional materials. Otherwise it might feel like a loophole. Plus the 952$3 needs to be written for the general public instead of for librarians when having allow_additional_materials_checkout=1. Or maybe these two points aren't really important, hence reaching for opinion here ^_^
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #11)
Lol perltidy puts tons of spaces to align $response with 'equals'.
check_field( $respcode, $response, FID_SCREEN_MSG, 'Item must be checked out at a circulation desk', 'Check screen msg', 'equals' );
I agree it's an interesting choice, but we have a community .perltidyrc as of bug 30002 and it's just doing what it's told to. If we don't like those results we should probably have a followup to bug 30002.
Last point to settle is whether allow_additional_materials_checkout should be on by default. I don't have an educated enough opinion on this.
I did not add the option to the debian SIPconfig.xml template, so it is off by default ( as it should be to retain current behavior ). The file etc/SIPconfig.xml is just an example file to demonstrate all the possible options in the SIP config, so it's fine to have it "enabled" there! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155920|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 156250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156250&action=edit Bug 34153: Add tests Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155921|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 156251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156251&action=edit Bug 34153: Add ability to allow items with additional materials notes to be checked out via SIP At this time, any item with an additional materials date is blocked from checkout via SIP with a screen message to take the item to a circulation desk for checkout. Some libraries wish to allow patrons to check out items via SIP even if the item has additional materials. Test Plan: 1) Create an item with an additional materials note 2) Attempt to check it out via SIP 3) Note the failure and message 4) Enable the new SIP account option "allow_additional_materials_checkout" 5) Restart the SIP server 6) Attempt the checkout again 7) Note the checkout success and new AF field message! 8) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155927|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 156252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156252&action=edit Bug 34153: (QA follow-up) Tidy code Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Kyle M Hall from comment #12)
I agree it's an interesting choice, but we have a community .perltidyrc as of bug 30002 and it's just doing what it's told to. If we don't like those results we should probably have a followup to bug 30002.
I know, that was the question, does it look like something worth tweaking our .perltidyrc?
The file etc/SIPconfig.xml is just an example file to demonstrate all the possible options in the SIP config
aaaaaah, ok all good then :D Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Great, but more a enhancement. Not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org