[Bug 38197] New: OPAC and staff interface Bootstrap files are out of sync
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Bug ID: 38197 Summary: OPAC and staff interface Bootstrap files are out of sync Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 Probably as a consequence of the delay between my work on the Bootstrap upgrade and the OPAC and the staff interface, the version of Bootstrap in the OPAC is behind the version in the staff interface. These should be the same. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Oh I'm looking at the Bootstrap file which was left behind and should have been removed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC and staff interface |Remove old version of |Bootstrap files are out of |Bootstrap JS left behind |sync |during upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 172892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172892&action=edit Bug 38197: Remove old version of Bootstrap JS left behind during upgrade This patch removes an old version of Bootstrap JS which should have been removed by Bug 35402. The correct Bootstrap JS file is at koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js This patch should have no effect on any OPAC functionality. Bootstrap-related features should still work: Dropdown menus, modals, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172892|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 172926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172926&action=edit Bug 38197: Remove old version of Bootstrap JS left behind during upgrade This patch removes an old version of Bootstrap JS which should have been removed by Bug 35402. The correct Bootstrap JS file is at koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js This patch should have no effect on any OPAC functionality. Bootstrap-related features should still work: Dropdown menus, modals, etc. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. No OPAC files are using the file removed (before and after the patch): git grep bootstrap/lib/bootstrap/bootstrap.bundle.min.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Not sure why the dir structure is not the same (extra 'js'), but that's for another day anyway koha-tmpl/opac-tmpl /lib/bootstrap/js/bootstrap.bundle.min.js koha-tmpl/intranet-tmpl/lib/bootstrap/bootstrap.bundle.min.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172926|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173018&action=edit Bug 38197: Remove old version of Bootstrap JS left behind during upgrade This patch removes an old version of Bootstrap JS which should have been removed by Bug 35402. The correct Bootstrap JS file is at koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js This patch should have no effect on any OPAC functionality. Bootstrap-related features should still work: Dropdown menus, modals, etc. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38197 Bug 38197 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org