[Bug 22821] New: Patron notes about item email notification fallback order is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Bug ID: 22821 Summary: Patron notes about item email notification fallback order is incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- In bug 19496 a fallback order for the email addresses (both to and from) was added. This fallback order appears to be incorrect per my understanding of the system preferences.
my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->ReplytoDefault || C4::Context->preference('KohaAdminEmailAddress');
My understanding is that branchemail is used for the 'from' address in emails from the branch, however it may not be an address which is accessible by the librarians (as to be allowed through spam filters for most popular email service the 'from' address domain has to match the domain of the sender server).. as such 'reply-to' address was added to allow for a library to send 'from' a proper domain but have 'replies' go to an email address they control.
my $from_address = $patron->email || $patron->emailpro || $patron->B_email;
We cannot spoof send emails from the patrons email address for the same reasons as outlined above. The email must come from the koha system but may happily contain the above fallback in the reply-to header to achieve what I believe is wanted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496 [Bug 19496] Patron notes about item does not get emailed as indicated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I am more than happy to mentor someone who might like to work on this, just reach out here or on IRC (I'm ashimema there) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22823 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 [Bug 22823] Koha::Library needs a method for obtaining the incoming email address -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22843 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu --- Comment #2 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I think our library is experiencing this bug. When a patron submits a note on an item through the OPAC, Koha sends the email to make it look like it came from the patron's email address. We are able to receive these emails if it is a patron email with the same domain (lancasterseminary.edu). A patron from a different domain (e.g., yahoo.com) had their OPAC note email returned to them because it couldn't be authenticated as coming from their domain. OPAC note emails need to come from the email address set in Koha admin instead of trying to look like they came from the patron. Are we on the same page, Martin? Or do I need to submit this as a separate bug? Thanks, Myka -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Myka, I think you are indeed experiencing this bug.. well.. half of it at least, I appear to explain two issues I suspect to be happening. I must admit, I had hoped someone would pick this up nearer the time I reported it.. I did try to encourage a few people to take a look. I'll try and put a quick patch together myself if you're willing to test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99559&action=edit Bug 22821: Add reply_address field to message_queue table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99560&action=edit Bug 22821: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99561&action=edit Bug 22821: Use 'reply-to' address in issue notes This patch updates the issue notices to not pass from_address and so default to the branch email of the user for from_address. We now pass the patrons email (cascading through email, emailpro, B_email) into the reply_address field so mail servers are less likely to report emails as spam and mail clients still have access to the patron address via the reply-to header when staff want to hit 'reply' and have the email go to the user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99562&action=edit Bug 22821: Correct to_address for issue notes This patch updates the controller and service code to use the newly introduced 'get_effective_email' routine from bug 22823 to obtain the branches most appropriate email address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99559|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99563&action=edit Bug 22821: Add reply_address field to message_queue table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99560|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99564&action=edit Bug 22821: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99561|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99565&action=edit Bug 22821: Use 'reply-to' address in issue notes This patch updates the issue notices to not pass from_address and so default to the branch email of the user for from_address. We now pass the patrons email (cascading through email, emailpro, B_email) into the reply_address field so mail servers are less likely to report emails as spam and mail clients still have access to the patron address via the reply-to header when staff want to hit 'reply' and have the email go to the user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99562|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99566&action=edit Bug 22821: Correct to_address for issue notes This patch updates the controller and service code to use the newly introduced 'get_effective_email' routine from bug 22823 to obtain the branches most appropriate email address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99563|0 |1 is obsolete| | --- Comment #12 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 99732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99732&action=edit Bug 22821: Add reply_address field to message_queue table Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99564|0 |1 is obsolete| | --- Comment #13 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 99733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99733&action=edit Bug 22821: Schema Update Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99565|0 |1 is obsolete| | --- Comment #14 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 99734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99734&action=edit Bug 22821: Use 'reply-to' address in issue notes This patch updates the issue notices to not pass from_address and so default to the branch email of the user for from_address. We now pass the patrons email (cascading through email, emailpro, B_email) into the reply_address field so mail servers are less likely to report emails as spam and mail clients still have access to the patron address via the reply-to header when staff want to hit 'reply' and have the email go to the user. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99566|0 |1 is obsolete| | --- Comment #15 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 99735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99735&action=edit Bug 22821: Correct to_address for issue notes This patch updates the controller and service code to use the newly introduced 'get_effective_email' routine from bug 22823 to obtain the branches most appropriate email address. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #16 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- These patches seem to fix the problem. Here was my test plan: 1. Created a simple SQL report (SELECT * FROM message_queue) 2. Ran report - results empty, no reply_address field 3. Applied patches 4. Restarted everything, updatedatabase, dbic 5. Ran report - results empty, new reply_address field appeared 6. Enabled AllowCheckoutNotes 7. Checked out an item to user with email address 8. Logged into OPAC as user 9. Entered a note for checked out item 10. Ran report - note email in results with user's email address appearing in reply_address field Thank you, Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent testing Myka, thankyou :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 [Bug 10269] add a way to define a specific replyto email address for some notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234 [Bug 2234] Make cart email from/reply-to/return-path address configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |3679 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679 [Bug 3679] Specify Reply-To address when emailing a list or cart from OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10269 Blocks|10269 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 [Bug 10269] add a way to define a specific replyto email address for some notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm going to move the reply-to handling into a submission for bug 10269 as that way it can then be a simple dependency for a bunch of other bugs that want it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99734|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99908&action=edit Bug 22821: Use 'reply-to' address in issue notes This patch updates the issue notices to not pass from_address and so default to the branch email of the user for from_address. We now pass the patrons email (cascading through email, emailpro, B_email) into the reply_address field so mail servers are less likely to report emails as spam and mail clients still have access to the patron address via the reply-to header when staff want to hit 'reply' and have the email go to the user. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99735|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99909&action=edit Bug 22821: Correct to_address for issue notes This patch updates the controller and service code to use the newly introduced 'get_effective_email' routine from bug 22823 to obtain the branches most appropriate email address. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99732|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2234 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234 [Bug 2234] Make cart email from/reply-to/return-path address configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3679 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679 [Bug 3679] Specify Reply-To address when emailing a list or cart from OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22823 | CC| |jonathan.druart@bugs.koha-c | |ommunity.org QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 84 my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->ReplytoDefault || C4::Context->preference('KohaAdminEmailAddress'); The C4::Context->ReplytoDefault was super wrong! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99908|0 |1 is obsolete| | Attachment #99909|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100938&action=edit Bug 22821: Use 'reply-to' address in issue notes This patch updates the issue notices to not pass from_address and so default to the branch email of the user for from_address. We now pass the patrons email (cascading through email, emailpro, B_email) into the reply_address field so mail servers are less likely to report emails as spam and mail clients still have access to the patron address via the reply-to header when staff want to hit 'reply' and have the email go to the user. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100939&action=edit Bug 22821: Correct to_address for issue notes This patch updates the controller and service code to use the newly introduced 'get_effective_email' routine from bug 22823 to obtain the branches most appropriate email address. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100940&action=edit Bug 22821: Rename method with ->inbound_email_address The method has been renamed in the previous bug report. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100944&action=edit Bug 24722: reserves.priority must default to 1 at DB level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel the description of the bug is not correct on this one, but not sure what it should be changed to - Martin, could you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prior to this patch when a release notes| |patron added an item note | |the system would send a | |notification email to the | |branchemail with a from | |address of the patrons | |email. | | | |This patch updates | |the notification system to | |use the 'reply-to' address | |in preference to the | |'branchemail' if it is | |defined and it also sets | |the 'from' address to the | |'branchemail' and adds the | |patron email as a | |'reply-to' as this was the | |intended functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron notes about item |Use reply-to address for |email notification fallback |item notes notifications if |order is incorrect |available to avoid being | |flagged as spam --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Given it a go with what I think it does - feel free to correct :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #30 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x due to dependencies -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org