[Bug 9979] New: convert ./C4/Installer/PerlDependencies.pm into a YAML file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Bug ID: 9979 Summary: convert ./C4/Installer/PerlDependencies.pm into a YAML file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: mtj@kohaaloha.com the current file in Koha with perl module data is not too user friendly this bug aims to replace it with a friendlier YAML version -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 17741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17741&action=edit Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file to test... - run 'before' dependancy test ./koha_perl_deps.pl -a > aa - apply patch git bz 9979 - run 'after' dependancy test ./koha_perl_deps.pl -a > bb - test for 0 differences diff aa bb |wc -l 0 - run test perl ./t/Installer_PerlDependencies.t 1..3 ok 1 - use C4::Installer::PerlDependencies; ok 2 - PerlDependencies.yml file parsed with no errors ok 3 - Parsed YAML matches PerlDependencies.yml file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17741|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 17752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17752&action=edit Bug 9979 - convert ./C4/Installer/PerlDependencies.pm into a YAML file to test... - run 'before' dependancy test ./koha_perl_deps.pl -a > aa - apply patch git bz 9979 - run 'after' dependancy test ./koha_perl_deps.pl -a > bb - test for 0 differences diff aa bb |wc -l 0 - run test perl ./t/Installer_PerlDependencies.t 1..3 ok 1 - use C4::Installer::PerlDependencies; ok 2 - PerlDependencies.yml file parsed with no errors ok 3 - Parsed YAML matches PerlDependencies.yml file Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Mason, could you rebase your patch against master please? qa comment: I think the yaml file should be somewhere else than into a C4 sub-directory. But I don't have a better suggestion... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Mason James from comment #0)
the current file in Koha with perl module data is not too user friendly
this bug aims to replace it with a friendlier YAML version
Can you expand on why you find this so unfriendly? Or why other developers would find it unfriendly, to well, write Perl code? Or provide use cases? Putting aside the current inability of the patch to apply, at the moment this seems to me to be a change purely for the sake of making a change. That's not to say that I have any particular attachment to the status quo in this case -- it would have been quite reasonable for Chris Nighswonger to have chosen YAML or JSON back in 2010 -- but the current state of affairs is also reasonable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 --- Comment #5 from Marc Véron <veron@veron.ch> --- Should this Bug have status "In Discussion"? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Marc Véron from comment #5)
Should this Bug have status "In Discussion"?
yeah, i'll switch it... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to Galen Charlton from comment #4)
(In reply to Mason James from comment #0)
the current file in Koha with perl module data is not too user friendly
this bug aims to replace it with a friendlier YAML version
Can you expand on why you find this so unfriendly? Or why other developers would find it unfriendly, to well, write Perl code? Or provide use cases?
Galen, currently, how can developers access Koha's required perl modules, using a different programming language than perl? afaik, they cant - thats unfriendly :( -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org