[Bug 37866] New: Unable to resolve claim from patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Bug ID: 37866 Summary: Unable to resolve claim from patron details page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If ones tries to resolve a claim from patrons detail page, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. To reproduce: 1. Find patron with claims (or create them). 2. Navigate to patrons detail page and from there open "Claims" tab. 3. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 4. Repeat from patrons check out page. => Pop up is displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I can't reproduce this bug in main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I was able reproduce this also in Biblibre sandbox. For some reason, even thought both patron Detail and Check out pages share the same code to create "Resolve" button and display pop up module, in Detail page clicking "Resolve" doesn't launch click function in resolve_claim_modal.js (first line). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- This happens when ClaimReturnedLostValue syspref is not enabled. In moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue _or_ BundleLostValue syspref is enabled. Here's updated plan to reproduce this bug: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat from patrons check out page. => Pop up is displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 171301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171301&action=edit Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171301|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171352&action=edit Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I was thinking about this some more, is it really wise to prevent pop up from launching if syspref is off but still display button in UI? It's kinda confusing for the user to have button there but no any kind of hint why it's not working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Emmi Takkinen from comment #6)
I was thinking about this some more, is it really wise to prevent pop up from launching if syspref is off but still display button in UI? It's kinda confusing for the user to have button there but no any kind of hint why it's not working.
Looks like the bug was a missed case from 66b35f50 - Bug 28854: Enable claims return view when BundleLostValue is set. The button (actually, all return claims functionality) is hidden if both ClaimReturnedLostValue and BundleLostValue are empty. So this should be fine - the check for BundleLostValue just got missed in this spot, causing the modal to not load when it should have. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171352|0 |1 is obsolete| | --- Comment #8 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 174438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174438&action=edit Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 174439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174439&action=edit Bug 37866: (QA follow-up) Fix another missed case Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37866 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- 24.05.x merge conflicts, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org