https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I think this was introduced by bug 34223 but I'm not sure why. Investigating. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156178&action=edit Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156178|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156200&action=edit Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that 4 warnings remain t/db_dependent/Koha/Illbackend.t .. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1956. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1961. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1956. Use of uninitialized value in exists at /kohadevbox/koha/Koha/Illrequest.pm line 1961. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156202&action=edit Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156218&action=edit Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156220&action=edit Bug 34838: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am still getting a lot of warnings t/db_dependent/Illrequests.t .. 1/15 illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 101. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 111. t/db_dependent/Illrequests.t .. 6/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. t/db_dependent/Illrequests.t .. 8/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 11/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 12/15 Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t .. 14/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 23040 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156217|0 |1 is obsolete| | Attachment #156218|0 |1 is obsolete| | Attachment #156219|0 |1 is obsolete| | Attachment #156220|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166841&action=edit [23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166843&action=edit [23.11.x] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166845&action=edit [23.11.x] Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166841|0 |1 is obsolete| | Attachment #166842|0 |1 is obsolete| | Attachment #166843|0 |1 is obsolete| | Attachment #166844|0 |1 is obsolete| | Attachment #166845|0 |1 is obsolete| | --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166846&action=edit [23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166848&action=edit [23.11.x] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166850&action=edit [23.11.x] Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166852&action=edit Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166854&action=edit Bug 34838: Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #15)

I am still getting a lot of warnings

Please check with my follow-up. There's a '23.11' and a 'main' version of the patch set. Besides the noise on the tests, this is a nightnmare on busy sites with some moderate ILL activity. as any action triggers many warnings per request that is displayed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** Bug 36918 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167194&action=edit [23.11.x] Bug 34838: (QA follow-up): TypeDisclaimer tests - Add 'type' to request metadata This adds a type to the request (mocking it as a new ILL request of type journal being submitted) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166851|0 |1 is obsolete| | Attachment #166852|0 |1 is obsolete| | Attachment #166853|0 |1 is obsolete| | Attachment #166854|0 |1 is obsolete| | Attachment #166855|0 |1 is obsolete| | Attachment #167193|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167211&action=edit Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167213&action=edit Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167215&action=edit Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #45 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for 24.05.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #47 from wainuiwitikapark@catalyst.net.nz --- not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #48 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.