[Bug 17809] New: ER country in fr-FR database files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Bug ID: 17809 Summary: ER country in fr-FR database files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Érythrée" (correct one) and "Allemagne". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ER country in fr-FR |ER country twice in fr-FR |database files |database files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 58390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58390&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Looking closer, please check: CC, ER, GQ, and PK as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- And confirm qualif 370 values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 [Bug 17837] Correct some authorised values in fr-FR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Going to sign off and put the issues raised in comment #2 into bug 17837. Comment #3 may not have any relevance, as the two french words clearly refer to different things and very well may be valid. I'll leave that to a native French speaker to determine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58390|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58577&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Frido, I think it would be great to have a update DB entry to check if this value exists. If it does, I do not think we should remove it, but at least warn the administrator that there is something wrong and something should be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #6)
Frido, I think it would be great to have a update DB entry to check if this value exists. If it does, I do not think we should remove it, but at least warn the administrator that there is something wrong and something should be fixed.
If I create a db update, simply replace in COUNTRY authorized value the description for "ER" into "Erythrée" if it is "Allemagne" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #7)
(In reply to Jonathan Druart from comment #6)
Frido, I think it would be great to have a update DB entry to check if this value exists. If it does, I do not think we should remove it, but at least warn the administrator that there is something wrong and something should be fixed.
If I create a db update, simply replace in COUNTRY authorized value the description for "ER" into "Erythrée" if it is "Allemagne" ?
Nope, I'd suggest just to display a warning message if (ER, Allemagne) exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #8)
Nope, I'd suggest just to display a warning message if (ER, Allemagne) exists.
So, don't correct it. Just give pretty red upgrade messages? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- yep -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59259&action=edit Bug 17809: Add upgrade warning messages TEST PLAN --------- 0) backup db 1) drop db and recreate empty 2) run fr-FR web install 3) update systempreferences set Value='16.00003' where variable='Version'; -- it is currently 16.00004 as of this writing 4) run fr-FR web install -- bottom of red warnings should be the check messages. 5) perlcritic -1 installer/data/mysql/atomic_update/bug_17809_pretty_red.perl -- $VERSION message, which we don't care about -- maybe a message about return value of print ignored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59261&action=edit Bug 17809 correct authorisation values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss <luke.honiss@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58577|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59262&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 17837 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- The first patch written by me needs signing off. The second patch written by me was signed off by Luke Honiss. The third patch written by Fridolin SOMERS was signed off by me. In short, I am setting this to needs sign off, because of the first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ER country twice in fr-FR |Correct some authorised |database files |values in fr-FR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am worried about the atomicupdate - it looks like only checks for the authorised value code, but not for the category, so this might lead to wrong warning messages. Some of those codes look like classifications we might have as collections in our databases for example. + my $number_cc = $schema->resultset('AuthorisedValue')->search( + { + authorised_value => 'CC' + } + )->count; + if ( $number_cc > 1 ) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #16)
I am worried about the atomicupdate - it looks like only checks for the authorised value code, but not for the category, so this might lead to wrong warning messages. Some of those codes look like classifications we might have as collections in our databases for example.
+ my $number_cc = $schema->resultset('AuthorisedValue')->search( + { + authorised_value => 'CC' + } + )->count; + if ( $number_cc > 1 ) {
Ideed. M. Tompsett can you work on it ? I do it if you want. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Fridolin SOMERS from comment #17)
(In reply to Katrin Fischer from comment #16)
I am worried about [SNIP]
Indeed. M. Tompsett can you work on it ? I do it if you want.
I'm not sure how to correct it. So if it is clear to you. You go ahead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 72099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72099&action=edit Bug 17809: (follow-up) search in COUNTRY category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Someone has to sign-off the last 2 patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59259|0 |1 is obsolete| | --- Comment #21 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72842&action=edit Bug 17809: Add upgrade warning messages TEST PLAN --------- 0) backup db 1) drop db and recreate empty 2) run fr-FR web install 3) update systempreferences set Value='16.00003' where variable='Version'; -- it is currently 16.00004 as of this writing 4) run fr-FR web install -- bottom of red warnings should be the check messages. 5) perlcritic -1 installer/data/mysql/atomic_update/bug_17809_pretty_red.perl -- $VERSION message, which we don't care about -- maybe a message about return value of print ignored. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59261|0 |1 is obsolete| | --- Comment #22 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72843&action=edit Bug 17809 correct authorisation values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss <luke.honiss@gmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59262|0 |1 is obsolete| | --- Comment #23 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72844&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72099|0 |1 is obsolete| | --- Comment #24 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72845&action=edit Bug 17809: (follow-up) search in COUNTRY category Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frido, please make sure to write your patch subjects according to the guidelines: Bug XXXXX: ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #26 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #25)
Hi Frido, please make sure to write your patch subjects according to the guidelines: Bug XXXXX: ...
Oups yes I'm aware of that now ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72842|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73107&action=edit Bug 17809: Add upgrade warning messages TEST PLAN --------- 0) backup db 1) drop db and recreate empty 2) run fr-FR web install 3) update systempreferences set Value='16.00003' where variable='Version'; -- it is currently 16.00004 as of this writing 4) run fr-FR web install -- bottom of red warnings should be the check messages. 5) perlcritic -1 installer/data/mysql/atomic_update/bug_17809_pretty_red.perl -- $VERSION message, which we don't care about -- maybe a message about return value of print ignored. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73108&action=edit Bug 17809: Correct authorised values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss <luke.honiss@gmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73109&action=edit Bug 17809: Fix ER country appearing twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72845|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73110&action=edit Bug 17809: (follow-up) search in COUNTRY category Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72843|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- $schema must not be used in updatedatabase.pl, use SQL queries instead Use warn instead of carp (like other entries). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we remove the draft status from here? https://wiki.koha-community.org/wiki/Database_updates#DBIx::Class_.28DRAFT.2... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #32)
Should we remove the draft status from here? https://wiki.koha-community.org/wiki/Database_updates#DBIx::Class_.28DRAFT.2...
Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #34 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- What next ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Waiting for concerns on comment 31 to be addressed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #36 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #35)
Waiting for concerns on comment 31 to be addressed.
Oh indeed. @Mark Tompsett tell me I you can't work on rewrite. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #37 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Authorised value CC for Coco/Keeling was fixed by Bug 22887 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #38 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ah but now during upgrade 19.12.00.071 Bug 22887, duplicates are detected. So we may only correct the sql file ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Frido, can you deal with this please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26622 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73108|0 |1 is obsolete| | --- Comment #40 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 113304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113304&action=edit Bug 17809: Correct authorised values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss <luke.honiss@gmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73109|0 |1 is obsolete| | --- Comment #41 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 113305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113305&action=edit Bug 17809: Fix ER country appearing twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #38)
Ah but now during upgrade 19.12.00.071 Bug 22887, duplicates are detected. So we may only correct the sql file ?
In order to move forward with this bug, it only correct the sql files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- root@kohadevbox:koha(BZ17809|BISECTING)$ koha-mysql kohadev < installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql ERROR 1062 (23000) at line 613: Duplicate entry 'qualif-370' for key 'authorised_values.av_uniq' Still not working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Bug 17809 depends on bug 22887, which changed state. Bug 22887 Summary: authorised_values is missing a unique constraint on category + authorised_value https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #44 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114713&action=edit Bug 17809: FR installer: fix duplicate authorised value qualif 370 Monteur vs Réalisateur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Failed QA |Needs Signoff --- Comment #45 from Victor Grousset/tuxayo <victor@tuxayo.net> --- With those patches, reset_all_unimarc finishes without errors in koha-testing-docker :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113304|0 |1 is obsolete| | --- Comment #46 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114758&action=edit Bug 17809: Correct authorised values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss <luke.honiss@gmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113305|0 |1 is obsolete| | --- Comment #47 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114759&action=edit Bug 17809: Fix ER country appearing twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114713|0 |1 is obsolete| | --- Comment #48 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114760&action=edit Bug 17809: FR installer: fix duplicate authorised value qualif 370 Monteur vs Réalisateur Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #49 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks a lot Victor ;) Hope it will soon be QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114758|0 |1 is obsolete| | Attachment #114759|0 |1 is obsolete| | Attachment #114760|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114792&action=edit Bug 17809: Correct authorised values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss <luke.honiss@gmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114792|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114795&action=edit Bug 17809: Correct authorised values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss <luke.honiss@gmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114796&action=edit Bug 17809: Fix ER country appearing twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 114797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114797&action=edit Bug 17809: FR installer: fix duplicate authorised value qualif 370 Monteur vs Réalisateur Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00, 20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #55 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #56 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #57 from Victor Grousset/tuxayo <victor@tuxayo.net> --- There is no dependency on bug 27331 right? It's related but the two bugs address different issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #57)
There is no dependency on bug 27331 right? It's related but the two bugs address different issues.
To test this on master and 20.11 you need it. For other branches you don't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org