https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110658|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110900&action=edit Bug 26519: Clean up OPAC buttons with incorrect classes This patch makes some corrections to the OPAC templates to add the correct classes to a few buttons which were missed during the Bootstrap 4 upgrade, especially in cases where the buttons only appear when JavaScript is disabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate the bibliographic record for a serial record and view the details. The subscription should have patron notification set. - Under the Subscriptions tab, the "Subscribe to email notifications" button should look correct. - Click to subscribe and confirm that the buttons during and after the process look correct. - Perform a catalog search in the OPAC. On the search results page, disable JavaScript. This can be done in the browser's developer tools under "Settings." - At the top of the table of search results there should be a correctly-styled "Go" button next to the sorting dropdown menu. It should work correctly. - View the contents of a list with JavaScript disabled. - The "Resort list" button should be correctly-styled and should work to submit the form. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110900|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111460&action=edit Bug 26519: Clean up OPAC buttons with incorrect classes This patch makes some corrections to the OPAC templates to add the correct classes to a few buttons which were missed during the Bootstrap 4 upgrade, especially in cases where the buttons only appear when JavaScript is disabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Locate the bibliographic record for a serial record and view the details. The subscription should have patron notification set. - Under the Subscriptions tab, the "Subscribe to email notifications" button should look correct. - Click to subscribe and confirm that the buttons during and after the process look correct. - Perform a catalog search in the OPAC. On the search results page, disable JavaScript. This can be done in the browser's developer tools under "Settings." - At the top of the table of search results there should be a correctly-styled "Go" button next to the sorting dropdown menu. It should work correctly. - View the contents of a list with JavaScript disabled. - The "Resort list" button should be correctly-styled and should work to submit the form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.