[Bug 15042] New: Barcode <branchcode>yymm0001 does not work when receiving serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Bug ID: 15042 Summary: Barcode <branchcode>yymm0001 does not work when receiving serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: magnus@libriotech.no Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com To reproduce: - Set autoBarcode = <branchcode>yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens Bug 11273, attachment 42372 changes the logic around locating the barcode field in the item table from this: - for (i=0 ; i<document.f.field_value.length ; i++) { - if (document.f.tag[i].value == '$args->{loctag}' && document.f.subfield[i].value == '$args->{locsubfield}') { To this: + var form = document.getElementById('f'); + if ( !form ) { + form = document.getElementById('Aform'); + } + for (i=0 ; i<form.field_value.length ; i++) { + if (form.tag[i].value == '$args->{loctag}' && form.subfield[i].value == '$args->{locsubfield}') { This works for the item table that adds items to a bib record: <form id="f" method="post" action="/cgi-bin/koha/cataloguing/additem.pl" name="f"> but not for the item table that you get when receiving a serials issue, which is missing the id="f": <form method="post" name="f" action="serials-edit.pl" id="serials_edit"> Patch coming! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 43680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43680&action=edit Item form with id=f -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 43681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43681&action=edit Item form without id=f -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- I thought this would be as easy as adding id="f" to the item form for receiving serials, but that changes the whole look of the form. See attached screenshots. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- D'oh, the form already has id="serials_edit". Patch coming in a sec. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 43684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43684&action=edit Bug 15042 - Barcode hbyymmincr does not work when receiving serials To test: - Set autoBarcode = <branchcode>yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens - Apply patch and reload page - Receive an issue - Click in the barcode field - a barcode conforming to the hbyymmincr setting appears -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43684|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 43741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43741&action=edit Bug 15042 - Barcode hbyymmincr does not work when receiving serials To test: - Set autoBarcode = <branchcode>yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens - Apply patch and reload page - Receive an issue - Click in the barcode field - a barcode conforming to the hbyymmincr setting appears Patch works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43741|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43743&action=edit Bug 15042 - Barcode hbyymmincr does not work when receiving serials To test: - Set autoBarcode = <branchcode>yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens - Apply patch and reload page - Receive an issue - Click in the barcode field - a barcode conforming to the hbyymmincr setting appears Patch works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not sure it's a major one, but definitely annoying. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org