[Bug 9503] New: Link from histsearch via invoicenumber results in error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Bug ID: 9503 Summary: Link from histsearch via invoicenumber results in error Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com The acq histsearch page displays invoice numbers and allows their selection to retrieve shipments recorded against that invoice. Selection results in an error: Can't use an undefined value as an ARRAY reference at /home/koha/kohaclone/acqui/parcel.pl line 160. Cause of the error is that the the invoice id is passed as invoice whereas parcel.pl expects invoiceid so that GetInvoiceDetails is incorrectly called and returns undef rather than an invoice structure -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 14913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14913&action=edit Proposed patch Testing: Without this patch applied selecting an invoicenumber from the acqui/histsearch screen results in a system error. With it applied a listing of related orders should be displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14919&action=edit Bug 9503 Correct name of parameter passed to parcel.pl invoiceid was being passed as invoice causing GetInvoiceDetails to silently fail and a system error downstream when accessing the 'orders' element of the undefined invoice Added an error message if GetInvoiceDetails called on undef Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14913|0 |1 is obsolete| | Attachment #14919|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 14920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14920&action=edit Bug 9503 Correct name of parameter passed to parcel.pl invoiceid was being passed as invoice causing GetInvoiceDetails to silently fail and a system error downstream when accessing the 'orders' element of the undefined invoice Added an error message if GetInvoiceDetails called on undef Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14973&action=edit Bug 9503: Followup Correct name of parameter passed to parcel.pl The booksellerid and datereceive parameters are useless. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Colin and Galen, In fact 2 parameters (booksellerid and datereceived) are useless. They are not used by the histsearch.pl script. Could one of you sign off this patch please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14973|0 |1 is obsolete| | --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 14981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14981&action=edit Follow up patch signed off Signed off Changed the commit line to more accurately indicate what patch changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks Colin. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14920|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14992&action=edit Bug 9503 Correct name of parameter passed to parcel.pl invoiceid was being passed as invoice causing GetInvoiceDetails to silently fail and a system error downstream when accessing the 'orders' element of the undefined invoice Added an error message if GetInvoiceDetails called on undef Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14981|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14993&action=edit Bug 9503: Followup remove unused parameters passed to parcel.pl The booksellerid and datereceive parameters are useless. Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- How do I get to the histsearch page? I can't seem to find it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #10)
How do I get to the histsearch page? I can't seem to find it.
From the acquisition home page, select the "Orders search" tab (in the header) and click on the submit button (or the "advanced search" link).
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9503 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org