[Bug 7166] New: Modify order notes when basket is closed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Bug #: 7166 Summary: Modify order notes when basket is closed Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: julian.maurice@biblibre.com QAContact: ian.walls@bywatersolutions.com Add possibility to edit order notes when the basket is closed. BibLibre infos: Repository: git://git.biblibre.com/koha_biblibre.git Branch: stetienne/ft/MT7603 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7163 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m AssignedTo|henridamien@koha-fr.org |jonathan.druart@biblibre.co | |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-01-06 11:40:10 UTC --- Created attachment 7068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7068 Proposed patch When you are on parcel.pl or basket.pl you can now add or edit a note for each order. To test: Create orders with and without note. Edit/Add the note on basket.pl page. Close the basket. Check you can add/edit the order note on parcel.pl page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 14:39:12 UTC --- The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply". The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix. If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script. If the patch applies does not apply as I think, please rebase and resubmit, thanks -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7068|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-17 15:20:39 UTC --- Created attachment 7736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7736 Bug 7166 Adds edit order notes when the basket is closed Rebased patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-24 06:42:39 UTC --- Hi Jonathan, your patch does not apply, I suspect 7113, but there is also a conflict in neworderempty.pl. Can you please fix and resubmit? Thank you. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7736|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-24 08:18:22 UTC --- Created attachment 7848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7848 Bug 7166 Adds edit order notes when the basket is closed Rebased patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 11:52:52 UTC --- Hi Jonathan, I have tested your patch and it works nicely. I think perhaps display and usability can be improved a little bit. What I found is not enough for a 'failed qa', but perhaps you can consider the suggestions for a follow up: 1) I think the note gets a bit lost in the colum with the title information. Perhaps a separate column displaying the notes and the links to add or change notes would be a bit nicer. 2) After saving the note you are not redirected to the page basket or parcel page, but first have to confirm again. I think redirecting directly to the page would be a bit nicer and save one step. 3) Not sure, but perhaps a better label for the button on the new order page would be "Save" or "Update" instead of "Change". I will attach some screenshots, so others can perhaps add their opinion without applying the patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7848|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 11:54:04 UTC --- Created attachment 7887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7887 [SIGNED-OFF] Bug 7166: Adds edit order notes when the basket is closed When you are on parcel.pl or basket.pl you can now add or edit a note for each order. To test: Create orders with and without note. Edit/Add the note on basket.pl page Close the basket. Check you can add/edit the order note on parcel.pl page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Feature works nicely. I added some notes about and ideas for usability and display to the bug report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 11:55:26 UTC --- Created attachment 7888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7888 new order note page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 12:00:11 UTC --- Created attachment 7889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7889 Order notes on basket page Screenshot shows how the order note gets a bit lost/hidden within the other information in that column. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-29 15:31:49 UTC --- Created attachment 7943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7943 Bug 7166 Followup redirect after editing the note This patch redirects to the correct page and changes the button label to "Save". Katrin, I fear that putting the note in a new column deforms the table, if this note is too long What do you thing about a "mouseover popup" to display the note ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2012-02-29 21:01:43 UTC --- Created attachment 7950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7950 Follow-up fix: Markup corrections and improvements Correcting markup issues with modordernotes.pl: - Adding "rows" and "cols" attributes to <textarea> (required) - Converting cancel button to link to stay consistent with other pages - Changing page layout to fixed & centered (not sidebar needed) - Expanding information in breadcrumbs to match information on basket.pl Changing markup around note add and edit links: Moving output of order note to the end of the table cell, putting it in its own paragraph, and adding a "Note:" label -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> 2012-02-29 21:10:45 UTC --- I noticed a very strange bug: When I'm on parcel.pl I don't see notes which I added or modified via modordernotes.pl. I thought notes were stored in the same place either way, but I see an example where parcel.pl doesn't show any notes for an order, but when I click "add note" the form on modordernotes.pl shows the data I entered previously. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-03-01 08:41:06 UTC --- Created attachment 7955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7955 Bug 7166 Followup Adds edit order notes when the basket Bug 7166: Followup: Adds edit order notes when the basket is closed FIX field aqorders.notes Hi Owen, In fact, there is an ambiguous field between biblio and aqorders tables. I fix the problem with this patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #14 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Something went wrong ! Applying: Bug 7166: Adds edit order notes when the basket is closed Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging acqui/neworderempty.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt Failed to merge in the changes. Patch failed at 0001 Bug 7166: Adds edit order notes when the basket is closed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7887|0 |1 is obsolete| | Attachment #7943|0 |1 is obsolete| | Attachment #7950|0 |1 is obsolete| | Attachment #7955|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8289&action=edit Bug 7166: Adds edit order notes when the basket is closed Rebased and Squashed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Edit/Add the note on basket.pl page and parcel.pl page. Everything is OK. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Ian Walls <koha.sekjal@gmail.com> --- Mostly a template-only change, with a small reordering of select columns in C4::Acquisition::GetPendingOrders(). Adds valuable functionality in it's own page and script. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7166 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Ok in master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org