https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com Depends on| |18857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18857 [Bug 18857] Have "actions" at both ends of the circulation rules table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 68719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68719&action=edit Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 [Bug 15486] Restrict number of holds placed by day -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68719|0 |1 is obsolete| | --- Comment #2 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 68789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68789&action=edit Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68847&action=edit Bug 19539: (follow-up) Fix column index shift in cirulation rules Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68846|0 |1 is obsolete| | Attachment #68847|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68879&action=edit Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68880|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68883&action=edit Bug 19539: (follow-up) Fix column index shift in cirulation rules Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.