https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #1 from Andrii Nugged <nugged@gmail.com> --- self-quoting from 23824#c18 ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824#c18 ) You can not save the report editing form in non-English interfaces anymore. I.e., this breaks how "Update" (saving form) works: in non-English Koha button's text becomes translated, what is desired for UI, but not for code, but the hidden "non-translated" value was removed: <input type="hidden" name="phase" value="Update SQL" /> And, if the button's content is translated, it doesn't matches the comparison in reports/guided_reports.pl to the "phase" parameter with hardcoded "Update SQL". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Somebody working on this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152248&action=edit Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 --- Comment #5 from Andrii Nugged <nugged@gmail.com> --- I solved that on production before in templates only :), <input type="submit" onclick="this.value='Update SQL'" name="phase" class="btn btn-primary" value="Update SQL" /> <input type="submit" onclick="this.value='Update and run SQL'" name="phase" class="btn btn-primary" value="Update and run SQL" /> in a hacky way, :facepalm: but now I will build our custom .deb with your patch, Jonathan, install on production, and sign-off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152248|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152267&action=edit Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152267|0 |1 is obsolete| | --- Comment #7 from Andrii Nugged <nugged@gmail.com> --- Created attachment 152274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152274&action=edit Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrii Nugged <nugged@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.01 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 [Bug 35936] Cannot save existing report with incorrect AV category -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.