[Bug 10285] New: Error 500 in staff client displays old start page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Bug ID: 10285 Summary: Error 500 in staff client displays old start page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@enger.priv.no CC: gmcharlt@gmail.com Created attachment 18241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18241&action=edit 500 error including old start page If you trigger a 500 internal server error in the the saff client, the old start page is displayed along with the error message. See attached screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I think this is okay. I don't think we want to display the full-styled home page as that might be confusing. I suspect, however, that we need to update the page to reflect changes since this was last updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still valid for master. Maybe we should just show the message and remove all the links to the modules below? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- (In reply to Katrin Fischer from comment #2)
This is still valid for master. Maybe we should just show the message and remove all the links to the modules below?
+1 from me. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- The relevant files are in koha-tmpl/intranet-tmpl/prog/en/modules/errors/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37821&action=edit Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37821|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37939&action=edit [SIGNED OFF] Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #7 from Nick Clemens <nick@quecheelibrary.org> --- Signed off, but worth noting, I didn't check 405.pl because I can't find it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Nick Clemens from comment #7)
Signed off, but worth noting, I didn't check 405.pl because I can't find it
$ git grep 405.t | grep -v "\.po:" generates nothing. 405 can be removed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Nick Clemens from comment #7)
Signed off, but worth noting, I didn't check 405.pl because I can't find it
HTTP error code 405 is "Method Not Allowed" -- disable post and get in your apache config, and see what wonderful kabooms occur? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37939|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38110&action=edit [PASSED QA] Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> http://bugs.koha-community.org/show_bug.cgi?id=10258 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- String changes held for 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Applied to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org