[Bug 42524] New: Option to calculate priorities based on reservedate when moving hold to a new record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Bug ID: 42524 Summary: Option to calculate priorities based on reservedate when moving hold to a new record Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Depends on: 31698 Currently, when a hold is moved to a new record the hold is placed at the end of the priority list. It would be helpful to provide an option to work the moved hold into the priority list based on when the hold was created -- the moved hold would go after older holds, before newer holds. This does present a problem if the new target record has holds whose priority has been manually changed so that they are no longer in order of age. For the merging of bib records we addressed this same issue by fully rebuilding the priority list for the new merged bib, discarding any manual priority changes and putting all holds in order of age. We could take the same approach here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 [Bug 31698] Add ability to move a hold to a new bibliographic record/item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42558 [Bug 42558] reserves.reservedate should be datetime instead of date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199344&action=edit Bug 42524: Add new HoldPriorityWhenMoved system preference Patch from commit d7ec6d6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199345&action=edit Bug 42524: Introduce and implement rebuild_priority_by_reservedate Patch from commit fcbd601 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199365&action=edit Bug 42524: rebuild_priority_by_reservedate unit test Patch from commit 896f646 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199477&action=edit Bug 42524: Update found paramaters in query Patch from commit 0df611d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199478&action=edit Bug 42524: Update move_hold unit tests Patch from commit 9bba7a7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199481&action=edit Bug 42524: Add new HoldPriorityWhenMoved system preference Patch from commit e09d93a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199482&action=edit Bug 42524: Introduce and implement rebuild_priority_by_reservedate TO TEST: 1. APPLY PACTHES, updatedatabase, restart_all 2. Search for the new HoldPriorityWhenMoved system preferences, It should be set to "last" by default 3. With it set to 'last' follow the test plan for Bug 31698, everything should remain the same 4. Now set the HoldPriorityWhenMoved system preference to 'reservedate' 5. Now place some holds on a new record, making note of the reserevedate. You can use `select reserve_id, priority, reservedate from reserves` to keep track 6. Place a hold on a different record than the one in step 5. 7. Place a few more holds on the same record from step 5, this way you have a mix of reservedate's 8. `select reserve_id, priority, reservedate from reserves` again and notice the reservedates 9. Now move the hold from step 7 to the bib from step 5. 10. Observe the reservedates, confirm that priority is now order by reservedate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199483&action=edit Bug 42524: rebuild_priority_by_reservedate unit test Patch from commit 0a63f5f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199484&action=edit Bug 42524: Update found paramaters in query Patch from commit 4570b3f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199485&action=edit Bug 42524: Update move_hold unit tests Patch from commit 2730312 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #11 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Is running through the complete test plan for 31698 required to test the functionality here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #12 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- I've been looking at moving both bib-level and item level holds in a sandbox. Moving bib-level holds looks good. Moving item-level holds is working, but I noticed that when I move item-level holds with HoldPriorityWhenMoved set to "last" the display of the hold priority shows by date with the priority still adding the moved holds to the end of the priority. An example screenshot is attached (HoldPriority_DisplayByDate.png) I will add another comment walking through what I have looked at, but I think this display quirk will confuse people. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #13 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Created attachment 201217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201217&action=edit HoldPriority_DisplayByDate.png -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This needs to be blocked until its dependencies can move. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #15 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Veering off the test plan, sharing what I have looked at with this patch in a sandbox: Bib-level holds: 1. On 6/18 place three record-level holds each on 4 bibs (15, 52, 123, 53) 2. On 6/19 place two record-level holds each on the same 4 bibs. 3. Without changing HoldPriorityWhenMoved (set at last priority) moved 2 records from 6/18 and one from 6/19 from bib 15 to 123. The holds appended to the end of the existing hold priority. The display was by hold priority 1-8. 4. Changed HoldPriorityWhenMoved to ReserveDate 5. Moved 4 holds, 2 from 6/18 and two from 6/19 from bib 52 to 53. The holds filed in order by date placed (Great!) Item-level holds: 1. On 6/26 place two item-level holds on each of 4 bibs (1/ barcode 3999900000001, 8/39999000000313, 6/39999000000238, 12/39999000000511). 2. On 6/29, place two item-level holds on each of these barcodes. 3. Without changing HoldPriorityWhenMoved (set at last priority) moved 3 item-level holds from 3999900000001 to 39999000000313. The holds appended to the end of the existing hold priority, but the display was by date placed, with the hold priority out of order (see screenshot HoldPriority_DisplayByDate.png) 4. Changed HoldPriorityWhenMoved to ReserveDate. 5. Moved 3 item-level holds from 39999000000238 to 39999000000511. The holds filed in order by date placed (Great!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199481|0 |1 is obsolete| | Attachment #199482|0 |1 is obsolete| | Attachment #199483|0 |1 is obsolete| | Attachment #199484|0 |1 is obsolete| | Attachment #199485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 204236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204236&action=edit Bug 42524: Add new HoldPriorityWhenMoved system preference Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 204237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204237&action=edit Bug 42524: Introduce and implement rebuild_priority_by_reservedate TO TEST: 1. APPLY PACTHES, updatedatabase, restart_all 2. Search for the new HoldPriorityWhenMoved system preferences, It should be set to "last" by default 3. With it set to 'last' follow the test plan for Bug 31698, everything should remain the same 4. Now set the HoldPriorityWhenMoved system preference to 'reservedate' 5. Now place some holds on a new record, making note of the reserevedate. You can use `select reserve_id, priority, reservedate from reserves` to keep track 6. Place a hold on a different record than the one in step 5. 7. Place a few more holds on the same record from step 5, this way you have a mix of reservedate's 8. `select reserve_id, priority, reservedate from reserves` again and notice the reservedates 9. Now move the hold from step 7 to the bib from step 5. 10. Observe the reservedates, confirm that priority is now order by reservedate Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 204238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204238&action=edit Bug 42524: rebuild_priority_by_reservedate unit test Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 204239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204239&action=edit Bug 42524: Update found paramaters in query Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42524 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 204240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204240&action=edit Bug 42524: Update move_hold unit tests Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org