http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11232 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 32554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32554&action=edit Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the "See more" link). - Jump to "See more", notice it shows more than 20 facet values. - Apply the patch, reload the page. => SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload => SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32553|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32667&action=edit [SIGNED-OFF] Bug 13088: Add a syspref so the user can chose the amount of facets to show This patch introduces a syspref (FacetMaxCount) that controls how many facets to show for each category (e.g. Author). Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32667|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32668&action=edit [SIGNED-OFF] Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the "See more" link). - Jump to "See more", notice it shows more than 20 facet values. - Apply the patch, reload the page. => SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload => SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test plan completed successfully -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32667|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32739&action=edit [PASSED QA] Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the "See more" link). - Jump to "See more", notice it shows more than 20 facet values. - Apply the patch, reload the page. => SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload => SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test plan completed successfully Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Passes tests and QA script, works as described. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 32844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32844&action=edit Bug 13088: (RM followup) add missing pref mock Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.