[Bug 14583] New: Subfields not deleted when automatically merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Bug ID: 14583 Summary: Subfields not deleted when automatically merging authorities. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: maxime.beaulieu@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This problem happens when editing autorities with syspref "dontmerge" enabled. Subfield deletion is not reflected in the referencing record. How to reproduce: 0) Set the "dontmerge" syspref to "Do" 1) Create an authority record. 2) Set values in the 245$a and 245$v subfields. 3) Edit or create a biliographic record and link the authority. 4) Edit the linked authority: remove the 245$v subfield add a value in the 245$z sufield 5) Check the authority values in the bibliographic record: The $v subfield is still there (merge failed) The $z subfield was added (merge worked) (subfields and $v and $z were arbitrarely chosen) A patch will follow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |maxime.beaulieu@inlibro.com Patch complexity|--- |Trivial patch CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 --- Comment #1 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- (In reply to Maxime Beaulieu from comment #0)
2) Set values in the 245$a and 245$v subfields.
Woops, field tag depends of the authority you create. Ex: 150 for TOPIC_TERM -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 --- Comment #2 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 41112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41112&action=edit Bug 14583 - Subfields not deleted when automatically merging authorities This problem happens when editing autorities with syspref "dontmerge" enabled. Subfield deletion is not reflected in the referencing record. How to test: 0) Set the "dontmerge" syspref to "Do" 1) Create a Topical Term authority record. 2) Set values in the 150$a and 150$v subfields. 3) Edit or create a biliographic record and link the authority. 4) Edit the linked authority: remove the 150$v subfield add a value in the 150$z sufield 5) Check the authority values in the bibliographic record: The $v subfield is still there (merge failed) The $z subfield was added (merge worked) 6) Apply the patch 7) Edit the linked authority: remove the 150$z subfield add a value in the 150$x sufield 8) Check the authority values in the bibliographic record: The deleted subfields are gone. modified: C4/AuthoritiesMarc.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13760 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5572 CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11315 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5264 Status|Needs Signoff |In Discussion CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- I can reproduce the issue you describe, and I confirm that your patch solves it. But a) your code leaves a variable ($exclude) which isn't used anymore, and b) you remove a portion of code which was introduced by bug 5264 (see also bug 5572). Have you tried solving your issue with bug 5572? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> ---
Have you tried solving your issue with bug 5572?
I have. It make it. You should use it, sign, and obsolete your patch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org