[Bug 31116] New: Article requests doesn't respect the 'CircSidebar' preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Bug ID: 31116 Summary: Article requests doesn't respect the 'CircSidebar' preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The article requests management page doesn't ever display the circulation side menu.. it should when CircSidebar is enabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137269&action=edit Bug 31116: Add circulation sidebar to article requests This patch adds the circulation sidebar menu to the article requests page to make it consistent with other circulation module pages. Test plan 1) Prior to applying the patch confirm that there is no sidebar on the article requests management page, regardless of the CircSidebar perference. 2) Apply the patch 3) Confirm there is still no sidebar when CircSidebar is disabled 4) Confirm there is now a sidebar present when CircSidebar is enabled 5) Confirm the current page is highlighted correctly in the sidebar when on the article requests page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137269|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 137313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137313&action=edit Bug 31116: Add circulation sidebar to article requests This patch adds the circulation sidebar menu to the article requests page to make it consistent with other circulation module pages. Test plan 1) Prior to applying the patch confirm that there is no sidebar on the article requests management page, regardless of the CircSidebar perference. 2) Apply the patch 3) Confirm there is still no sidebar when CircSidebar is disabled 4) Confirm there is now a sidebar present when CircSidebar is enabled 5) Confirm the current page is highlighted correctly in the sidebar when on the article requests page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137313|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137361&action=edit Bug 31116: Add circulation sidebar to article requests This patch adds the circulation sidebar menu to the article requests page to make it consistent with other circulation module pages. Test plan 1) Prior to applying the patch confirm that there is no sidebar on the article requests management page, regardless of the CircSidebar perference. 2) Apply the patch 3) Confirm there is still no sidebar when CircSidebar is disabled 4) Confirm there is now a sidebar present when CircSidebar is enabled 5) Confirm the current page is highlighted correctly in the sidebar when on the article requests page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137362&action=edit Bug 31116: (QA follow-up) Remove duplicate line Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- My only comment would be: Article requests is considered as Circulation, so it would be fine for me if it would have been listed under Circulation. Patron request is added now. All circulation stuff is based on 'patron requests' ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I totally agree actually.. I just followed what the circulation-home page does in terms of splitting them. I'd be happy to remove the 'Patron requests' section from both and move 'Article requests' under circulation for consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply clean to 22.05.x, no backport. If needed please rebase -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org