[Bug 32352] New: xt/check_makefile.t failing on node_modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Bug ID: 32352 Summary: xt/check_makefile.t failing on node_modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org 21:55:20 koha_1 | # Failed test 'All directories must be listed in Makefile.PL' 21:55:20 koha_1 | # at xt/check_makefile.t line 39. 21:55:20 koha_1 | # got: '1' 21:55:20 koha_1 | # expected: '0' 21:55:20 koha_1 | # $VAR1 = [ 21:55:20 koha_1 | # './node_modules' 21:55:20 koha_1 | # ]; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, mtj@kohaaloha.com, | |tomascohen@gmail.com Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144242&action=edit Bug 32352: Make xt/check_makefile.t check directories in git index It's failing if 'node_modules' exists. We could simply skip it, but it seems that it would be better to actually list directories that are part of the git index only. The question is: do we actually support test execution outside of a git directory? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just a dumb question :) What about: The dir should exist, right? diff --git a/Makefile.PL b/Makefile.PL index 131d8a0ae2..9d4eb9d604 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -346,6 +346,7 @@ my $target_map = { './misc/translator' => { target => 'MISC_DIR', trimdir => 2 }, './misc/koha-install-log' => { target => 'MISC_DIR', trimdir => -1 }, './misc/installer_devel_notes' => 'NONE', + './node_modules' => 'INTRANET_CGI_DIR', './opac' => 'OPAC_CGI_DIR', './OpenILS' => 'PERL_MODULE_DIR', './README.txt' => 'NONE', -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- No, it shouldn't in production env. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- And it's not part of git index, so not necessarily exists on dev env either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Checking the git tree feels like the right approach. Must admit, I've never tried to run the tests from outside of the kohaclone.. but that's doesn't mean there isn't someone out there doing that. I think I'd suggest going with this patch and documenting that the expectation is that tests are run from inside the project somewhere. I can't see any obvious flaws with this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I agree only checking things in the git tree is the right approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144242|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144283&action=edit Bug 32352: Make xt/check_makefile.t check directories in git index It's failing if 'node_modules' exists. We could simply skip it, but it seems that it would be better to actually list directories that are part of the git index only. The question is: do we actually support test execution outside of a git directory? Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00, 22.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 22.11.x for 22.11.01 release. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33743 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 [Bug 34911] Test suite no longer run test critic -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org