[Bug 18889] New: Item number in biblio description in fine page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Bug ID: 18889 Summary: Item number in biblio description in fine page Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: vimal0212@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 64772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64772&action=edit Fines Dear Friends, Very useful to see the item number (barcode) along with bibliographic details in fines page. If barcode appears along with book details easy identify the specific book. For example, in law libraries books with the same title by many authors (e.g. Constitution of India). Please see the screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 vimal kumar <vimal0212@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |amitddng135@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 69352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69352&action=edit Bug 18889 - Storing and display of barcode with fines in intranet Test plan: 1. Create a manual invoice fine making sure you enter in a barcode value 2. Go to the 'Pay fines' tab and notice that the barcode value is not displayed 3. Apply patch 4. Update your database by running the updatedatabase.pl script in koha-shell This will run the atomicupdate file bug_18889_added_barcode_field_to_accountlines.sql which contains the database changes 5. Update your DBIx by running the command (in the Koha root directory): misc/devel/update_dbix_class_files.pl --db_name=<dbname> --db_user=<dbuser> --db_pass=<dbpass> 6. Repeat step 1 and 2 and notice that there is a new front end column in the 'Pay fines' page which displays the item barcode Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|amitddng135@gmail.com |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david.bourgault@inlibro.com --- Comment #2 from David Bourgault <david.bourgault@inlibro.com> --- Patch had a minor conflict when applying. When following test plan I got the following: Software error: DBIC result _type isn't of the _type Category at members/moremember.pl line 138. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 73362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362&action=edit Bug 18889 - Storing and display of barcode with fines in intranet Test plan: 1. Create a manual invoice fine making sure you enter in a barcode value 2. Go to the 'Pay fines' tab and notice that the barcode value is not displayed 3. Apply patch 4. Update your database by running the updatedatabase.pl script in koha-shell This will run the atomicupdate file bug_18889_added_barcode_field_to_accountlines.sql which contains the database changes 5. Update your DBIx by running the command (in the Koha root directory): misc/devel/update_dbix_class_files.pl --db_name=<dbname> --db_user=<dbuser> --db_pass=<dbpass> 6. Repeat step 1 and 2 and notice that there is a new front end column in the 'Pay fines' page which displays the item barcode Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 73365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73365&action=edit Patch applies cleanly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 73366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73366&action=edit Circled barcode in the pay fines table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I have recorded some screencast videos showing the behaviour of the bug before applying the patch and following the test plan after applying the patch and running steps 4 and 5. If you are testing this and are confused about the test plan I will happily email these videos to you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362 Bug 18889 - Storing and display of barcode with fines in intranet Review of attachment 73362: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18889&attachment=73362) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +281,4 @@
date => \'NOW()', amount => $amount, description => $desc, + barcode => $barcode,
Why pass barcode when the itemnumber is available? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73519&action=edit Bug 18889: Simpler counter-patch There is no need to add barcode into the accountlines table, as a relationship via itemnumber can easily look it up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Counter Patch Test Plan ------------------------ 1) Add a manual fine with a barcode to a member. 2) Look at the pay invoice tab. -- no barcode shown. 3) apply counter patch only patch -- and no updatedatabase or rebuilding tables required! 4) restart_all (silly plack caching) 5) refresh the pay invoice tab. -- barcode now displayed. 6) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #10 from Séverine Queune <severine.queune@bulac.fr> --- The 'Simpler counter-patch' doesn't apply.
Applying: Bug 18889: Simpler counter-patch Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt M members/pay.pl Falling back to patching base and 3-way merge... error: Your local changes to the following files would be overwritten by merge: members/pay.pl Please, commit your changes or stash them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 18889: Simpler counter-patch The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch
Barcode display is good applying only the first patch 'Storing and display of barcode with fines in intranet'. I'm not sure if I can sign or failed it because of the conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #11 from Séverine Queune <severine.queune@bulac.fr> --- Should title be "Add barcode to 'Fines' tab in biblio description" or something like that ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Séverine Queune from comment #10)
The 'Simpler counter-patch' doesn't apply.
It does by itself. That's the point of the counter-patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- In order to apply just one or the other. On a kohadevbox: git checkout -b bug_18889_t1 origin/master git bz apply 18889 i -- that's interactive, and then you put # at the beginning of the line you do not want I'll leave the setting of titles up to someone else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item number in biblio |Add barcode to 'Pay Fines' |description in fine page |tab in patrons payment page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73519|0 |1 is obsolete| | --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 75197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75197&action=edit Bug 18889: Simpler counter-patch There is no need to add barcode into the accountlines table, as a relationship via itemnumber can easily look it up. Followed test plan, works as described. Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75197|0 |1 is obsolete| | --- Comment #15 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 75198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75198&action=edit Bug 18889: Simpler counter-patch Works OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Please adjust commit title and body 2. Table footer is broken - https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org 3. Why a new column? Maybe it would make more sense to have it in the first column, close to the biblio's title? Failing QA for 1 and 2, Discussion for 3. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #17 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #16)
1. Please adjust commit title and body 2. Table footer is broken - https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org 3. Why a new column? Maybe it would make more sense to have it in the first column, close to the biblio's title?
Failing QA for 1 and 2, Discussion for 3.
The current master has a barcode column in the Patrons 'Make a payment' tab. Does anything need to be done further for this bug or shall I mark it resolved? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de Status|Failed QA |RESOLVED --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Hayley Mapley from comment #17)
(In reply to Jonathan Druart from comment #16)
1. Please adjust commit title and body 2. Table footer is broken - https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org 3. Why a new column? Maybe it would make more sense to have it in the first column, close to the biblio's title?
Failing QA for 1 and 2, Discussion for 3.
The current master has a barcode column in the Patrons 'Make a payment' tab. Does anything need to be done further for this bug or shall I mark it resolved?
You are right, it looks like it has been resolved already. It's also visible on the transactions tab. In this case you can mark "RESOLVED FIXED". If you are aware of the other bug that fixed it, you could also link them or 'Mark as duplicate'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #19 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #18)
(In reply to Hayley Mapley from comment #17)
(In reply to Jonathan Druart from comment #16)
1. Please adjust commit title and body 2. Table footer is broken - https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org 3. Why a new column? Maybe it would make more sense to have it in the first column, close to the biblio's title?
Failing QA for 1 and 2, Discussion for 3.
The current master has a barcode column in the Patrons 'Make a payment' tab. Does anything need to be done further for this bug or shall I mark it resolved?
You are right, it looks like it has been resolved already. It's also visible on the transactions tab. In this case you can mark "RESOLVED FIXED". If you are aware of the other bug that fixed it, you could also link them or 'Mark as duplicate'.
Thank you for all of your help Katrin on the various bugs you've commented on, it's very useful as a newbie to learn the best practices for the process :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Thank you for all of your help Katrin on the various bugs you've commented on, it's very useful as a newbie to learn the best practices for the process :)
Please feel free to catch me on IRC too if there are any questions! :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org