https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Nina Martinez <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |nina.martinez@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 --- Comment #1 from Nina Martinez <nina.martinez@biblibre.com> --- Created attachment 182539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182539&action=edit Bug 39890: Add search, menu and footer skip links to the OPAC. Before starting the test plan, you have to enable the following system preferences: CurbsidePickup, useDischarge, OPACHoldsHistory, ILLModule,EnhancedMessagingPreferencesOPAC, CookieConsent, OPACPrivacy, opacreadinghistory, UseRecalls, OPACHoldRequests, RoutingSerials, EnableOpacSearchHistory, virtualshelves,suggestion, OPACViewOthersSuggestions, TagsEnabled, OpacTopissue,OPACVirtualCard. Test plan: A) Add skip link to menu 1. Apply the patch, you don't have to be logged in for this part. 2. Go to these different pages: search result page, record details page (try the different views), and Most popular page. 3. Try navigating with the keyboard, fix the focus at the top of the page 4. You should see a skip link in red, 'skip to menu' appear. After pressing enter, the focus should be on the menu. 5. Now go to these different pages: Purchase suggestions page, search history page, Lists page. 6. Repeat the third step and check if the skip link "Skip to menu" does not appear on these pages. 7. Now you have to log in to a patron account. 8. Go to your Summary page. 9. Repeat the third step with the different pages of the menu (Summary, Charges, Personal details, Consents, Tags, Change password, Search history, Checkout history, Privacy, Holds history, Recalls history, Purchase suggestions, Messaging, Lists, Ask for discharge, Interlibrary loan request, Curbside pickups, My virtual card). 10. You should see the "Skip to menu" link, after pressing enter, the focus should be on the menu. B) Add a skip link to the search box 1. Try navigating with the keyboard, fix the focus on the top of the page. 2. Check if there is a skip link "Skip to the search" in red on each page of the OPAC, except on the advanced search page. C) Add a skip link to the footer 1. Try navigating with the keyboard, fix the focus at the top of the OPAC page. 2. Check if there is a skip link 'Skip to footer' after the skip link 'Skip to main content' on each page of the OPAC. 3. Now, disable the system preferences (OPACReportProblem and KohaAdminEmailAddress, CookieConsent, OpacKohaUrl, OpacLangSelectorMode = 'both', or OpacLangSelectorMode = 'footer') to remove the OPAC footer. 4. Repeat step 2. Now, you should not have the skip link to the footer. D) If all the tests succeed, sign off ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40165 [Bug 40165] Incomplete logic for controlling display of OPAC language footer -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182539|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183344&action=edit Bug 39890: Add search, menu and footer skip links to the OPAC. Before starting the test plan, you have to enable the following system preferences: CurbsidePickup, useDischarge, OPACHoldsHistory, ILLModule,EnhancedMessagingPreferencesOPAC, CookieConsent, OPACPrivacy, opacreadinghistory, UseRecalls, OPACHoldRequests, RoutingSerials, EnableOpacSearchHistory, virtualshelves,suggestion, OPACViewOthersSuggestions, TagsEnabled, OpacTopissue,OPACVirtualCard. Test plan: A) Add skip link to menu 1. Apply the patch, you don't have to be logged in for this part. 2. Go to these different pages: search result page, record details page (try the different views), and Most popular page. 3. Try navigating with the keyboard, fix the focus at the top of the page 4. You should see a skip link in red, 'skip to menu' appear. After pressing enter, the focus should be on the menu. 5. Now go to these different pages: Purchase suggestions page, search history page, Lists page. 6. Repeat the third step and check if the skip link "Skip to menu" does not appear on these pages. 7. Now you have to log in to a patron account. 8. Go to your Summary page. 9. Repeat the third step with the different pages of the menu (Summary, Charges, Personal details, Consents, Tags, Change password, Search history, Checkout history, Privacy, Holds history, Recalls history, Purchase suggestions, Messaging, Lists, Ask for discharge, Interlibrary loan request, Curbside pickups, My virtual card). 10. You should see the "Skip to menu" link, after pressing enter, the focus should be on the menu. B) Add a skip link to the search box 1. Try navigating with the keyboard, fix the focus on the top of the page. 2. Check if there is a skip link "Skip to the search" in red on each page of the OPAC, except on the advanced search page. C) Add a skip link to the footer 1. Try navigating with the keyboard, fix the focus at the top of the OPAC page. 2. Check if there is a skip link 'Skip to footer' after the skip link 'Skip to main content' on each page of the OPAC. 3. Now, disable the system preferences (OPACReportProblem and KohaAdminEmailAddress, CookieConsent, OpacKohaUrl, OpacLangSelectorMode = 'both', or OpacLangSelectorMode = 'footer') to remove the OPAC footer. 4. Repeat step 2. Now, you should not have the skip link to the footer. D) If all the tests succeed, sign off ! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi! I tried testing this but the patch is not applying cleanly. Could you please rebase this? I'd be happy to QA if you do! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183344|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189561&action=edit Bug 39890: Add search, menu and footer skip links to the OPAC. Before starting the test plan, you have to enable the following system preferences: CurbsidePickup, useDischarge, OPACHoldsHistory, ILLModule,EnhancedMessagingPreferencesOPAC, CookieConsent, OPACPrivacy, opacreadinghistory, UseRecalls, OPACHoldRequests, RoutingSerials, EnableOpacSearchHistory, virtualshelves,suggestion, OPACViewOthersSuggestions, TagsEnabled, OpacTopissue,OPACVirtualCard. Test plan: A) Add skip link to menu 1. Apply the patch, you don't have to be logged in for this part. 2. Go to these different pages: search result page, record details page (try the different views), and Most popular page. 3. Try navigating with the keyboard, fix the focus at the top of the page 4. You should see a skip link in red, 'skip to menu' appear. After pressing enter, the focus should be on the menu. 5. Now go to these different pages: Purchase suggestions page, search history page, Lists page. 6. Repeat the third step and check if the skip link "Skip to menu" does not appear on these pages. 7. Now you have to log in to a patron account. 8. Go to your Summary page. 9. Repeat the third step with the different pages of the menu (Summary, Charges, Personal details, Consents, Tags, Change password, Search history, Checkout history, Privacy, Holds history, Recalls history, Purchase suggestions, Messaging, Lists, Ask for discharge, Interlibrary loan request, Curbside pickups, My virtual card). 10. You should see the "Skip to menu" link, after pressing enter, the focus should be on the menu. B) Add a skip link to the search box 1. Try navigating with the keyboard, fix the focus on the top of the page. 2. Check if there is a skip link "Skip to the search" in red on each page of the OPAC, except on the advanced search page. C) Add a skip link to the footer 1. Try navigating with the keyboard, fix the focus at the top of the OPAC page. 2. Check if there is a skip link 'Skip to footer' after the skip link 'Skip to main content' on each page of the OPAC. 3. Now, disable the system preferences (OPACReportProblem and KohaAdminEmailAddress, CookieConsent, OpacKohaUrl, OpacLangSelectorMode = 'both', or OpacLangSelectorMode = 'footer') to remove the OPAC footer. 4. Repeat step 2. Now, you should not have the skip link to the footer. D) If all the tests succeed, sign off ! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nina or Owen (maybe?) - could you have a look at the QA check fail here? [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc FAIL valid_template jsinclude: not found Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)

I tried to test this, but I am not sure what I am looking for. I ran yarn build and now I can't seem to get the promised links to show up. I clicked at the top of several pages and used "Tab" to navigate. Can I get some more clues please?

I need some help here, failing to raise attention. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #10)

This still works for me. Could you try again?

Could you try extending/rephrasing the test plan? I think I got stuck because I didn#t know exactly what I was looking for. Or maybe a screenshot? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #12)

The steps to test the new controls are the same as for the "Skip to main content" link added by Bug 22807.

- From an OPAC page, click an empty spot somewhere at the top of the page - Hit shift-tab until your tab focus goes past the Koha logo. - A "Skip to..." button should appear. - With this patch, instead of just "Skip to main content" you should also see "Skip to footer" and "Skip to search" as you tab through.

Thanks Owen, this really helped :) I found it's easiest to click right behind the URL input in Firefox as then you have a 'short click way' to see the new controls. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189561|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.